Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic filter is not always working #4417

Closed
bsclifton opened this issue May 13, 2019 · 1 comment · Fixed by brave/brave-core#2486
Closed

Cosmetic filter is not always working #4417

bsclifton opened this issue May 13, 2019 · 1 comment · Fixed by brave/brave-core#2486
Assignees
Labels

Comments

@bsclifton
Copy link
Member

bsclifton commented May 13, 2019

Test plan

See brave/brave-core#2486

Description

For most sites, you can:

  1. right click somewhere on site
  2. choose Brave menu
  3. choose Block element via selector
  4. alert box with selector should show up

Step 4 (the alert) is not always happening. Even if you wait it out. This may be related to the changes made with brave/brave-core#2043

Steps to Reproduce

  1. Visit https://www.reddit.com/ or https://www.benzworld.org/forums/w126-s-se-sec-sel-sd/ or another site with the problem
  2. Right click on the ad, pick Block element via selector (as outlined above)

Actual result:

Nothing happens

Expected result:

Should be an input box with selector:
Screen Shot 2019-05-13 at 11 37 26 AM

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? haven't tried
  • Can you reproduce this issue with the beta channel? haven't tried
  • Can you reproduce this issue with the dev channel? y
  • Can you reproduce this issue with the nightly channel? y

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n
  • Does the issue resolve itself when disabling Brave Rewards? n
  • Is the issue reproducible on the latest version of Chrome? n
@bsclifton bsclifton added the feature/shields/adblock Blocking ads & trackers with Shields label May 13, 2019
@bsclifton bsclifton changed the title Cosmetic filter is not working Cosmetic filter is not always working May 13, 2019
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 24, 2019
@bsclifton bsclifton added this to the 0.68.x - Nightly milestone Jun 12, 2019
@btlechowski
Copy link

btlechowski commented Jul 30, 2019

Verification passed on

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#2486
Verified pages from the description.

image

image

Verification passed on

Brave 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verified passed with

Brave 0.68.116 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants