Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recurring tip amount change not immediately reflected on external monitor #4505

Closed
LaurenWags opened this issue May 20, 2019 · 6 comments
Closed
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards OS/macOS priority/P4 Planned work. We expect to get to it "soon". QA/Test-Plan-Specified QA/Yes

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #2823

If I change the 'Tip this site monthly' value in panel while Brave is displayed on my laptop screen, the change is made immediately. If I do this while using my external monitor to show Brave, the change isn't made until I close and reopen the panel. Same session, same site.

Steps to Reproduce

  1. Clean install
  2. Enable Rewards and fund wallet.
  3. Display Brave on an external monitor.
  4. Navigate to a verified site.
  5. Set up monthly tip.
  6. Open panel from BAT logo and change 'Tip this site monthly' value to be something different in the drop list.

Actual result:

Nothing happens, original value is displayed until you close and re-open the panel.
externalmonitor

Expected result:

Value changes immediately (this happens when I use my laptop monitor)
laptopmonitor

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? unsure but probably yes.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @brave/legacy_qa

@jdkuki
Copy link

jdkuki commented May 22, 2019

Reproduced on

Brave 0.67.42 Chromium: 75.0.3770.38 (Developer Build) (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Mac OS X

The issue does not exist when the external display is set as the primary monitory.

@jdkuki
Copy link

jdkuki commented May 28, 2019

Issue has been difficult to track down. Would be helpful to see if issue is reproducible on Linux or Windows.

@LaurenWags
Copy link
Member Author

not sure if maybe @kjozwiak or @srirambv have an external monitor that they could try on Win/Linux for this one (I've only got Win/Linux VMs).

@kjozwiak
Copy link
Member

kjozwiak commented May 30, 2019

not sure if maybe @kjozwiak or @srirambv have an external monitor that they could try on Win/Linux for this one (I've only got Win/Linux VMs).

Using 0.65.114 Chromium: 75.0.3770.38, went through the following platforms:

  • Win 10 x64 - Couldn't reproduce
  • Mint 19.1 x64 - Couldn't reproduce
  • macOS 10.14.5 x64 - Reproduced

Seems like it's macOS only.

** macOS Example:**

externalMonitormacOS

Win 10 x64 Example:

externalMonitorWin

@LaurenWags
Copy link
Member Author

thanks for taking a look @kjozwiak 😄

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 8, 2021

New panel doesn't have this dropdown anymore -- it sends you back to tipping banner.

@Miyayes Miyayes closed this as completed Oct 8, 2021
@Miyayes Miyayes added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards OS/macOS priority/P4 Planned work. We expect to get to it "soon". QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

5 participants