Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't disable content-level tips #4559

Closed
LaurenWags opened this issue May 23, 2019 · 2 comments · Fixed by brave/brave-core#2503
Closed

can't disable content-level tips #4559

LaurenWags opened this issue May 23, 2019 · 2 comments · Fixed by brave/brave-core#2503

Comments

@LaurenWags
Copy link
Member

Description

Unable to disable content-level tips.

Steps to Reproduce

  1. Install twitter tip enabled nightly.
  2. Enable Rewards
  3. Navigate to brave://rewards page
  4. Click on settings in Tips panel.
  5. Try to uncheck Twitter.

Actual result:

Unable to uncheck Twitter.

Expected result:

Able to uncheck Twitter.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.67.55 Chromium: 75.0.3770.38 (Official Build) nightly(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the dev channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @brave/legacy_qa @mandar-brave @alexwykoff @jenn-rhim

@emerick
Copy link
Contributor

emerick commented May 25, 2019

@NejcZdovc I think the problem is in the ON_INLINE_TIP_SETTINGS_CHANGE reducer, where it makes this check:

if (!value || value === '') {
  break
}

Seems like that will prevent a false value from ever being allowed...

@LaurenWags
Copy link
Member Author

LaurenWags commented Jul 10, 2019

Verified passed with

Brave 0.67.106 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X

Verification passed on

Brave 0.67.108 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment