Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweeting about a tip doesn't include youtube or twitch in canned tweet #4586

Closed
LaurenWags opened this issue May 23, 2019 · 0 comments
Closed
Labels
bug feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes

Comments

@LaurenWags
Copy link
Member

Description

After tipping a YouTube channel or Twitch channel, you have the option to Tweet about your tip. When you do this, the canned tweet text doesn't include 'on YouTube' or 'on Twitch' as appropriate.

Steps to Reproduce

  1. Navigate to verified YT or Twitch channel.
  2. Tip a video, stream, etc.
  3. On 'Thank you' banner, click on Tweet button.

Actual result:

On the tweet, you will not see 'on YouTube' or 'on Twitch' as appropriate. ex: https://twitter.com/bravelaurenwags/status/1131666887694311424

Expected result:

Should have 'on YouTube' or 'on Twitch' if appropriate.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.67.55 Chromium: 75.0.3770.38 (Official Build) nightly(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the dev channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @brave/legacy_qa @mandar-brave @alexwykoff @jenn-rhim

@NejcZdovc NejcZdovc added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label May 27, 2019
@NejcZdovc NejcZdovc added priority/P3 The next thing for us to work on. It'll ride the trains. and removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels May 30, 2019
jdkuki added a commit to brave/brave-core that referenced this issue May 30, 2019
jdkuki added a commit to brave/brave-core that referenced this issue May 31, 2019
Remove deprecated API and replace with args->GetList()
Fixes brave/brave-browser#4586
@Miyayes Miyayes added priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 20, 2023
@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants