Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit person setting is missing #4615

Closed
srirambv opened this issue May 27, 2019 · 20 comments
Closed

Edit person setting is missing #4615

srirambv opened this issue May 27, 2019 · 20 comments
Assignees
Labels

Comments

@srirambv
Copy link
Contributor

Description

Edit person setting is missing. Found while verifying #4333

Steps to Reproduce

  1. Install beta/dev/nightly profile
  2. Person settings is missing
  3. Can't edit the the profile to add some cool new profile icons

Actual result:

image

Expected result:

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.65.107 Chromium: 75.0.3770.38 (Official Build) beta(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux
Brave 0.66.76 Chromium: 75.0.3770.38 (Official Build) dev(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux
Brave 0.67.62 Chromium: 75.0.3770.38 (Official Build)nightly (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? No Chrome still has the option under Chrome name and picture on Chrome release and Beta as well

Miscellaneous Information:

cc: @bsclifton @petemill @rebron @brave/legacy_qa

@srirambv
Copy link
Contributor Author

+1 from @tggir1 via #4929

@kjozwiak
Copy link
Member

kjozwiak commented Jun 14, 2019

+1 from me as well. Bit annoying that you can't edit the default user. You would have to create a new user, change the icon, remove the initial one that was created and use the one you've created as the default.

@jkys
Copy link

jkys commented Jun 15, 2019

+1 would require having to resync the profiles and add back in the different customizations if I was to make a new profile to be able to edit the name and icon

@ghost
Copy link

ghost commented Jun 17, 2019

+1 Really annoying when you can't edit existing users at all so creating a new user is required to make changes

@imtbl
Copy link

imtbl commented Jun 17, 2019

Another +1.

@M-Brody
Copy link

M-Brody commented Jun 24, 2019

+1 on both linux and mac.

@houruomu
Copy link

+1 on windows

@theophanemayaud
Copy link

I get the issue on the current browser ! OP said "Can you reproduce this issue with the current release? No". Well, I definitely can 😉
Or maybe the download link from the brave website actually got me a dev version ? I've got :
Brave | 0.65.121 Chromium: 75.0.3770.100 (Build officiel) (64 bits)
Capture d’écran 2019-06-29 à 23 41 32

@imtbl
Copy link

imtbl commented Jul 3, 2019

I get the issue on the current browser ! OP said "Can you reproduce this issue with the current release? No".

This is probably because when OP created the issue, this feature had been working in 0.64.x (at least in some way; iirc, I was able to edit the default user and change the name/image back then), which was the current release at that time.

@Leon0402
Copy link

Leon0402 commented Jul 7, 2019

+1 on linux + mac

@Brave-Matt
Copy link

Several +1s from Reddit:
https://www.reddit.com/r/brave_browser/comments/cezd24/how_do_i_change_a_person/

@renaldofreire
Copy link

  • 1 linux and mac

@sebas-w
Copy link

sebas-w commented Jul 22, 2019

+1

Info

OS: macOS Mojave version 10.14.5 (18F132)
Brave Browser: Version 0.66.100 Chromium: 75.0.3770.142 (Official Build) (64-bit)

When Attempting to access the manage profile url directly I'm redirect to the settings page. The URL I've tried to access is: brave://settings/manageProfile

@arnydo
Copy link

arnydo commented Jul 24, 2019

+1 Version 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)

@mb300sd
Copy link

mb300sd commented Aug 2, 2019

+1 Version 0.67.123 Chromium: 76.0.3809.87 (Official Build) (64-bit)

@Brave-Matt
Copy link

+1
https://www.reddit.com/r/brave_browser/comments/cmky9k/cannot_edit_the_users_avatar_name/

@Leon0402
Copy link

@bsclifton
Copy link
Member

I believe @petemill is checking this out...

@petemill
Copy link
Member

Yep just waiting for a review at brave/brave-core#3140 :-)

@rebron
Copy link
Collaborator

rebron commented Aug 22, 2019

Closing as fixed in 70.x and dupe of #5211.

@rebron rebron closed this as completed Aug 22, 2019
@rebron rebron added closed/duplicate Issue has already been reported and removed release-notes/include labels Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests