Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Software Brave help needs to changed to Brave Help #4618

Closed
srirambv opened this issue May 27, 2019 · 8 comments
Closed

Brave Software Brave help needs to changed to Brave Help #4618

srirambv opened this issue May 27, 2019 · 8 comments
Labels
bug feature/global-settings Settings at browser level independent of shields settings feature/search feature/user-interface All UI related l10n priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Brave Software Brave help needs to changed to Brave Help

Steps to Reproduce

  1. Open settings page
  2. Search for an in-existent functionality like test
  3. Help center link has a weird text says Brave Software Brave Help

Actual result:

image

Expected result:

Should just say Brave help

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.65.107 Chromium: 75.0.3770.38 (Official Build) beta(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@srirambv srirambv added bug feature/user-interface All UI related feature/global-settings Settings at browser level independent of shields settings priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include labels May 27, 2019
@bbondy
Copy link
Member

bbondy commented May 28, 2019

Does title casing depend on the OS?

@srirambv
Copy link
Contributor Author

Actually looks like Linux only. I don't see it on Windows/mac release version

Windows:
image
macOS:
Screen Shot 2019-05-28 at 3 56 42 PM

@srirambv
Copy link
Contributor Author

srirambv commented Jan 8, 2020

Issue happens when locale is set to anything else apart from English (US). Setting it to English(Canada) reproduces the issue

@btlechowski
Copy link

btlechowski commented Jan 8, 2020

Reproduced on Windows 7 x64 for English(Canada) locale

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 7 Service Pack 1 (Build 7601.24530)

image

@LaurenWags
Copy link
Member

Reproduces on macOS also (Australian English)

Brave 1.3.86 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)

Screen Shot 2020-01-08 at 4 22 16 pm

@kjozwiak
Copy link
Member

kjozwiak commented Jan 8, 2020

@rebron @bsclifton not sure how important it is to be displaying Brave Software Brave help vs Brave help but as mentioned above, most locales that aren't US will see the above.

Maybe we would reconsider the P4 rating and move it to a P3?

@bsclifton
Copy link
Member

Looks like somewhere along the line (maybe Chromium 80 upgrade?) this was resolved:
Screen Shot 2020-03-04 at 3 27 00 PM

@rebron
Copy link
Collaborator

rebron commented Mar 4, 2020

Tried in 1.4.95 for Windows Australian English and again in Canadian English/Canada eh ;-) and saw only Brave Help.

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/global-settings Settings at browser level independent of shields settings feature/search feature/user-interface All UI related l10n priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include
Projects
None yet
Development

No branches or pull requests

7 participants