Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic refcode is not set for stub installer pings #4619

Open
btlechowski opened this issue May 27, 2019 · 4 comments
Open

Generic refcode is not set for stub installer pings #4619

btlechowski opened this issue May 27, 2019 · 4 comments
Labels
OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes

Comments

@btlechowski
Copy link

btlechowski commented May 27, 2019

Description

The stub installer is sending 3pings which contain the ref code.
The generic refcode implemented in #2547 is not used.

Steps to Reproduce

  1. Unpack BraveUpdate.zip and copy to c:\
  2. Uninstall Brave
  3. Delete Brave profile
  4. Delete c:\Program Files (x86)\BraveSoftware\
  5. Delete C:\ProgramData\BraveSoftware\
  6. Run stub installer
  7. Check C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log for the 3 pings

Actual result:

none is used instead of generic code.

[05/28/19 00:06:58.931][BraveBrowserBetaSetup v0.65.111][3428:11080][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=none&event=startup][request=][filename=]
[05/28/19 00:07:17.817][BraveUpdate:goopdate][4360:5852][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.65.107&channel=beta&ref=none&event=download-complete][request=][filename=]
[05/28/19 00:07:18.733][BraveUpdate:goopdate][4360:5852][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.65.107&channel=beta&ref=none&event=installer-run][request=][filename=]

Full log: BraveUpdate.log

Expected result:

Generic code BRV001 is used

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.65.107 Chromium: 75.0.3770.38 (Official Build) beta (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Windows 10 OS Version 1803 (Build 17134.523)

cc @brave/legacy_qa
Not sure how important are those pings cc @emerick @rebron @davidtemkin

@emerick
Copy link
Contributor

emerick commented May 28, 2019

@aekeus Let me know if this needs to get in there, we would just need to update our Omaha client since it's affecting the stub installer.

@rebron
Copy link
Collaborator

rebron commented May 28, 2019

cc: @mbacchi Can you take a look at this one?

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 28, 2019
@GeetaSarvadnya
Copy link

The issue is Reproducible on Brave beta 0.65.113.
BraveUpdate.log

@kjozwiak
Copy link
Member

@rebron @aekeus @mbacchi any updates on this one? Is priority/P3 appropriate? I know we've been working hard making sure that the generic pings are working correctly so not 100% sure where this stands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes
Projects
Status: P3 Backlog
Development

No branches or pull requests

5 participants