Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync UI paddings #4650

Closed
AlexeyBarabash opened this issue May 30, 2019 · 2 comments · Fixed by brave/brave-core#2673
Closed

Sync UI paddings #4650

AlexeyBarabash opened this issue May 30, 2019 · 2 comments · Fixed by brave/brave-core#2673
Assignees
@cezaraugusto
Labels
about-pages/sync feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude web-ui
Milestone
0.67.x - Release

Comments

@AlexeyBarabash
Copy link
Contributor

AlexeyBarabash commented May 30, 2019 •
edited
Loading

Description

Paddings of boxes on Sync UI page became zero.

Steps to Reproduce

  1. Open brave://sync/

Actual result:

Screenshot from 2019-05-30 12-38-26
Screenshot from 2019-05-30 12-36-37

Expected result:

How it looked before
Screenshot from 2019-05-30 14-14-53

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 0.67.69 Chromium: 75.0.3770.38 (Official Build)nightly (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? no
  • Can you reproduce this issue with the dev channel? no
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:
@AlexeyBarabash AlexeyBarabash mentioned this issue Jun 5, 2019
Closed
@bsclifton bsclifton added priority/P3 The next thing for us to work on. It'll ride the trains. regression QA/Yes labels Jun 5, 2019
@btlechowski
Copy link

Reproduced on

Brave 0.67.73 Chromium: 75.0.3770.38 (Official Build) dev (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Windows 7 Service Pack 1 (Build 7601.24465)

image

cezaraugusto added a commit to brave/brave-core that referenced this issue Jun 12, 2019
@cezaraugusto
add missing component to sync ui
4a530d7 
fix brave/brave-browser#4650

should match spec in brave-ui https://brave.github.io/brave-ui

missing components can be found in
https://github.com/brave/brave-ui/blob/master/stories/features/sync/enabledContent.tsx#L201
https://github.com/brave/brave-ui/blob/master/stories/features/sync/disabledContent.tsx#L75
@cezaraugusto cezaraugusto mentioned this issue Jun 12, 2019
Merged
@cezaraugusto cezaraugusto added this to the 0.68.x - Nightly milestone Jun 12, 2019
@brave-builds brave-builds mentioned this issue Jun 13, 2019
Merged
4 tasks
@LaurenWags
Copy link
Member

LaurenWags commented Jul 10, 2019 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 0.67.106 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X
  • Verified STR from description
    Screen Shot 2019-07-10 at 2 24 50 PM
    Screen Shot 2019-07-10 at 2 24 07 PM

Verification passed on

Brave 0.67.106 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the STR from the description

image

image

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Linux

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
about-pages/sync feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude web-ui
Projects
Sync - All platforms
Archived in project
Milestone
0.67.x - Release
Development

Successfully merging a pull request may close this issue.

add missing component to sync ui brave/brave-core
6 participants
@cezaraugusto @bsclifton @AlexeyBarabash @LaurenWags @btlechowski @GeetaSarvadnya