-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shields sometimes shows disabled on a tab even when its enabled #505
Closed
srirambv opened this issue
Jul 7, 2018
· 6 comments
· Fixed by brave/brave-extension#64 or brave/brave-core#483
Closed
Shields sometimes shows disabled on a tab even when its enabled #505
srirambv opened this issue
Jul 7, 2018
· 6 comments
· Fixed by brave/brave-extension#64 or brave/brave-core#483
Labels
bug
feature/shields
The overall Shields feature in Brave.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
Milestone
Comments
I've noticed this happen too |
I can reproduce this issue on all tabs which are inactive upon browser launch. Here's the correct steps
|
seems like a lifecycle issue I'll be on it next week as soon I finish sync ui |
Verification PASSED on
Verification Passed on
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
feature/shields
The overall Shields feature in Brave.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
Description
Shields sometimes shows disabled on a tab even when its enabled
Steps to Reproduce
Actual result:
Expected result:
Should not show disabled icon when shields is enabled for a site
Reproduces how often:
100% on 2ae4e74
Brave version (about:brave info)
2ae4e74
Reproducible on current release:
Website problems only:
Additional Information
cc: @cezaraugusto @bbondy
The text was updated successfully, but these errors were encountered: