Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme change only updates webUI and not URL bar #5464

Closed
srirambv opened this issue Jul 30, 2019 · 5 comments
Closed

Theme change only updates webUI and not URL bar #5464

srirambv opened this issue Jul 30, 2019 · 5 comments

Comments

@srirambv
Copy link
Contributor

Description

Theme change only updates webUI and not URL bar

Steps to Reproduce

  1. Upgrade to 0.69.94
  2. Toggle theme from dark to light
  3. Only webui theme changes, URL bar remains dark

Actual result:

devtheme

Expected result:

Should change both webui and URL bar theme accordingly

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.69.94 Chromium: 76.0.3809.62 (Official Build) dev (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Linux

Version/Channel Information:

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Similar to #5462

@simonhong
Copy link
Member

@srirambv When user choose GTK+ theme instead of Classic, gtk theme is used instead of brave theme by brave/brave-core#2905.
So, native ui such as url bar will not be changed by changing brave theme option.
With Classic theme, brave theme change will change webui & native ui both.

@rebron
Copy link
Collaborator

rebron commented Aug 9, 2019

@simonhong This doesn't sound like a bug. Working as expected?

@simonhong simonhong self-assigned this Aug 27, 2019
@simonhong
Copy link
Member

simonhong commented Aug 27, 2019

@rebron sorry for late reply. yes, this is expected behavior.

@srirambv
Copy link
Contributor Author

@simonhong should we close if this is the expected behaviour? (Its still weird that you have to mouse over for the change to happen and not automatic)

@simonhong
Copy link
Member

@srirambv This can be closed. After changing theme option, native ui(ex, omnibox) doesn't change at all. I can't see ui change during the mouse hover?

@simonhong simonhong added this to the Dupe / Invalid / Not actionable milestone Aug 30, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone Sep 23, 2019
@rebron rebron removed the QA/Yes label Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants