Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C78 buttons, tabs and Location Bar have lost brave-style corners #6426

Closed
petemill opened this issue Oct 11, 2019 · 6 comments · Fixed by brave/brave-core#3668
Closed

C78 buttons, tabs and Location Bar have lost brave-style corners #6426

petemill opened this issue Oct 11, 2019 · 6 comments · Fixed by brave/brave-core#3668

Comments

@petemill
Copy link
Member

Description

C78 update has caused a layout regression. Toolbar buttons, tabs and Location Bar now have chromium-style border radius and not brave-style.

Steps to Reproduce

  1. Open a Brave window
  2. Observe the Location Bar, and hover state on toolbar buttons

Actual result:

image

Expected result:

image

Reproduces how often:

100%

Brave version (brave://version info)

Version 0.72.90 Chromium: 78.0.3904.50 (Official Build) nightly (64-bit)

Version/Channel Information:

Only C78

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@LaurenWags
Copy link
Member

LaurenWags commented Oct 21, 2019

Verified passed with

Brave 0.70.119 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description

Screen Shot 2019-10-21 at 11 44 34 AM

Screen Shot 2019-10-21 at 11 45 15 AM

Verification passed on

Brave 0.70.119 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description

image

image

Verification passed on

Brave 0.70.119 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Ubuntu 18.04 LTS
  • Verified STR from the description

@srevinsaju
Copy link

I dunno if its okay to ask. 😅 , but is it possible to make Brave look like this?

Image

not by default, but as a per user configuration? Or is it set at build time?

@LaurenWags
Copy link
Member

@srevinsaju if you're on desktop and you go to brave://settings/newTab, there is a "New tab page shows" option. You can change that to "Blank page". If you are on dark theme it will make your new tab show like this:

Screen Shot 2021-01-25 at 7 21 30 AM

@srevinsaju
Copy link

srevinsaju commented Jan 25, 2021

Oh oops, I mean, the border-radius. I wanted to know if I could increase brave's border radius so that it looks more like chrome 😅

Somewhat like this:
Screenshot_20210125_122959

@LaurenWags
Copy link
Member

ah, gotcha @srevinsaju. I don't believe we have any such setting. cc @rebron

@srevinsaju
Copy link

It would be nice to have any type of configuration, like editing a css file, or a brave://flags, except building brave from sources. (wishlist ✨ )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment