Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS failing tests #6515

Closed
NejcZdovc opened this issue Oct 17, 2019 · 1 comment · Fixed by brave/brave-core#5493 or brave/brave-core#6408
Closed

macOS failing tests #6515

NejcZdovc opened this issue Oct 17, 2019 · 1 comment · Fixed by brave/brave-core#5493 or brave/brave-core#6408
Assignees
@bridiver
Labels
dev-concern OS/macOS QA/No release-notes/exclude tests
Milestone
1.14.x - Release #1

Comments

@NejcZdovc
Copy link
Contributor

Tests are failing on macOS with this error (browser and unit):

00:50:14  python ../../build/gn_run_binary.py /usr/bin/install_name_tool -change @loader_path/../../Libraries/libadblock.dylib @executable_path/gen/adblock/out/x86_64-apple-darwin/release/libadblock.dylib brave_unit_tests
00:50:14  error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: changing install names or rpaths can't be redone for: brave_unit_tests (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)

https://staging.ci.brave.com/job/brave-browser-build-pr/job/recurring-tips/11/execution/node/722/log/
https://staging.ci.brave.com/job/brave-browser-build-pr/job/recurring-tips/11/execution/node/705/log/
@bsclifton
Copy link
Member

@bridiver is -headerpad or -headerpad_max_install_names something we need to add to https://github.com/brave/brave-core/blob/master/test/BUILD.gn ?

@NejcZdovc NejcZdovc mentioned this issue Oct 17, 2019
Merged
32 tasks
@bsclifton bsclifton mentioned this issue Nov 3, 2019
Merged
@bsclifton bsclifton mentioned this issue Nov 20, 2019
Merged
4 tasks
@mkarolin mkarolin mentioned this issue Dec 6, 2019
Merged
28 tasks
@bsclifton bsclifton mentioned this issue Dec 9, 2019
Merged
32 tasks
@mkarolin mkarolin mentioned this issue Feb 25, 2020
Merged
32 tasks
@bsclifton bsclifton mentioned this issue Mar 2, 2020
Merged
4 tasks
@bsclifton bsclifton mentioned this issue Apr 26, 2020
Merged
@bsclifton bsclifton mentioned this issue May 6, 2020
Merged
4 tasks
This was referenced Jun 2, 2020
Merged
Merged
This was referenced Jun 10, 2020
Merged
Merged
@bridiver bridiver mentioned this issue Jun 22, 2020
Merged
32 tasks
@bsclifton bsclifton mentioned this issue Jul 24, 2020
Merged
32 tasks
@tmancey tmancey mentioned this issue Aug 11, 2020
Merged
32 tasks
@bridiver bridiver mentioned this issue Aug 12, 2020
Merged
32 tasks
@bridiver bridiver reopened this Aug 12, 2020
@bridiver bridiver added this to the 1.14.x - Nightly milestone Aug 16, 2020
@bridiver bridiver self-assigned this Aug 16, 2020
@kjozwiak kjozwiak mentioned this issue Aug 26, 2020
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bridiver bridiver

Labels
dev-concern OS/macOS QA/No release-notes/exclude tests
Projects
None yet
Milestone
1.14.x - Release #1
4 participants
@bridiver @bsclifton @rebron @NejcZdovc