Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrome://wallet is blocked when Brave Wallet is disabled #6903

Closed
aussiechief opened this issue Nov 13, 2019 · 2 comments
Closed

chrome://wallet is blocked when Brave Wallet is disabled #6903

aussiechief opened this issue Nov 13, 2019 · 2 comments

Comments

@aussiechief
Copy link

Description

The chrome://wallet (brave://wallet) page is blocked if Brave Wallet is turned off in Extension options.

Steps to Reproduce

  1. Go to chrome://settings/extensions
  2. Switch"Brave Wallet" to off
  3. Click "Crypto Wallets" in the top Settings navigation menu OR go to chrome://wallet

Actual result:

ERR_BLOCKED_BY_CLIENT

Link to screenshot 1
Link to screenshot 2

Expected result:

The "Crypto Wallets" Settings navigation menu item should be hidden when Brave Wallets is disabled (#6393). Chrome://wallet should redirect to chrome://rewards or a different page.

Reproduces how often:

Each time

Brave version (brave://version info)

Brave: 1.0.0 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision: 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS: Windows 10 OS Version 1903 (Build 18362.476)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Yes (Version 1.0)
  • Can you reproduce this issue with the beta channel?
    Not checked
  • Can you reproduce this issue with the dev channel?
    Not checked
  • Can you reproduce this issue with the nightly channel?
    Not checked

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No
  • Does the issue resolve itself when disabling Brave Rewards?
    No
  • Is the issue reproducible on the latest version of Chrome?
    NA

Miscellaneous Information:

@tildelowengrimm tildelowengrimm added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 14, 2019
@szaimen
Copy link

szaimen commented Nov 22, 2019

I would also like to see this implemented.
It is a little bit annoying that the button on the top doesn't get hidden automatically.
Also when disabling Brave Wallet, it should ask for a restart: #6902

@bbondy
Copy link
Member

bbondy commented Dec 20, 2019

This will be deprecated with this work so closing this issue since it'll be handled there:
#7503

@bbondy bbondy closed this as completed Dec 20, 2019
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants