Shortcuts / apps on macOS throws exception 'NSInvalidArgumentException' instantly #7205
Comments
|
After some digging I've found that BetterSnapTool (https://folivora.ai/bettersnaptool) seems to be causing the problems. I'll try and see if I can find what exactly is causing this and why it's actually causing Brave to crash (and not BetterSnapTool) |
|
Did some more digging and it seems this is a bug in Brave, rather than BetterSnapTool. The I've asked the BetterSnapTool developer about his knowledge about this particular type of crash: "Maybe Brave uses a different kind of custom window for more customisability or something like that. In that case they should either disable Accessibility support completely for that window or implement all the required methods (or at least add stubs so it won't crash when macOS calls them)." (https://community.folivora.ai/t/bettersnaptool-and-bettertouchtool-cause-brave-web-browser-apps-to-crash/12299/5) @bsclifton would you be able to elaborate? Also, it seems this should be tagged as a bug rather than a feature? |
|
@bsclifton no, I don't use the digital keyboard, but BetterSnapTool does use many of the accessibility features, so I could be calling the same methods which make Brave crash |
|
I can confirm that this is the reason for my instant crashes too. Launched app shortcuts created with Brave causes the app to crash after any user interaction (ex, clicking on toolbar). Closing BetterSnapTool solves this issue. I can also confirm that this doesn't happen for shortcut apps created by Chrome - just Brave app shortcuts. |
|
+1 from Community user: |
|
@Brave-Matt great if you could get some developer eyes on this! |
|
Same issue here with Better Touch Tool :( |
|
I've had to kill the process. I miss my shortcuts 😢... I cry a little bit everytime I have to reach for my mouse to resize a window 😭😆 |
|
@mdbraber @melMass @digitalmaster can you all please try the Nightly build of Brave? Try to create a shortcut and see if you run into the same problem. There's a good chance (with Chromium 83, which is on master and will be on Beta soon) it will be fixed If that does fix it, we have a release coming next week 😄 |
|
@bsclifton thanks for picking this up! Something has changed, but unfortunately for the worse: Nightly unfortunately instantly crashes now instead of after moving a window. Same error it seems: Here's the stack trace: |
|
@bsclifton Thanks for looking into this. Exact same behavior for me. Crashes as soon as I perform some action (like trying to drag the window). |
|
Assuming |
|
I'm looking in to this, it's been affecting me this whole time |
bsclifton
added
priority/P3
|
+1 - I do not use BetterSnap or BetterTouch, however seeing the same problem. Apps work fine with Chrome, but crashes on Brave. Thanks for looking into this @petemill ! |
|
cc: @jumde |
|
I hear https://community.brave.com/t/bug-report-macos-accessibility-immediately-causes-brave-web-apps-to-close/156666 is also caused by this. |
|
One more shoutout that I'm running into this problem with BetterSnapTool. I see it's recently been escalated to p1, which is cool. |
|
Still happening for me on the latest prod build. |
|
Just wanted to add the application "Witch" to the list of applications that cause this issue. I had hopes that it would circumvent the issue by being a PrefPane application, but it still has a daemon running that requires the Accessibility APIs. |
|
Hi folks - this may be fixed with Chromium 92 which will be in product version 1.27 which we're aiming to release soon. When this new version pops up, please let us know if the issue is resolved 😄 If you're using Beta or Nightly, you should already have the update |
|
I can confirm this issue has been resolved for me in version 1.27. |
|
Can confirm my issue related to better touch tool functionality seems to be resolved as well! |
|
Great, thanks for confirming folks! I'll go ahead and close this issue 😄 |
|
sadly I still run into that issue all the time, even with bettertouchtool & bettersnapttool dsiabled - after each update, the standalone apps open in a blank tab and dont load. the only thing that works for me is:
but this is annoying :( |
|
I'm still having this issue, with no success following any of the fixes above. I'm on [Version 1.35.104 Chromium: 98.0.4758.109 (Official Build) (arm64)] Any open with window shortcut I create just immediately crashes, no window ever appears. The app icon in MacOS just blinks when you double-click on it. |
|
Updated to V 1.35.104 and now experiencing this with all PWAs |
|
@craigmdennis Please make a new issue, the error is way too generic, it probably has a different stack trace. |
|
I have this: https://community.brave.com/t/updating-to-1-35-104-breaks-all-pwas/346680 but have no idea how to debug because no window even opens. |
|
After installing and attempting to launch a PWA, I get this in my MacOS terminal
|
This comment was marked as off-topic.
This comment was marked as off-topic.
|
I have created a new issue: #21302 |
|
@craigmdennis that's the way to go 👍🏻. Now it gets the attention is needs. |
and others
Description
When creating an 'app' on macOS 10.15.1 it immediately throws the following error:
Steps to Reproduce
Actual result:
Briefly shows website in separate window, crashes right after. Shows the error above. Full error when launching
app_mode_loaderseparately:Expected result:
Display a separate window with the specific website and not crash ;-)
Reproduces how often:
Always reproducible
Brave version (brave://version info)
Version/Channel Information:
Can you reproduce this issue with the current release?
Yes
Can you reproduce this issue with the beta channel?
Yes
Can you reproduce this issue with the dev channel?
Did not try
Can you reproduce this issue with the nightly channel?
Did not try
Other Additional Information:
Does the issue resolve itself when disabling Brave Shields?
No
Does the issue resolve itself when disabling Brave Rewards?
No
Is the issue reproducible on the latest version of Chrome?
No - tried latest version of Chromium (Version 77.0.3865.90 (Official Build) (64-bit)) and this works fine
Similar reports
This issue has already been reported in the community forums thrice by others:
The text was updated successfully, but these errors were encountered: