Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add up to to AC settings #7277

Closed
NejcZdovc opened this issue Dec 9, 2019 · 1 comment · Fixed by brave/brave-core#4179
Closed

Add up to to AC settings #7277

NejcZdovc opened this issue Dec 9, 2019 · 1 comment · Fixed by brave/brave-core#4179
Assignees
@NejcZdovc
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.3.x - Release

Comments

@NejcZdovc
Copy link
Contributor

Right now we don't have up to in AC settings, where we have it on default view. We need to add it
@NejcZdovc NejcZdovc added needs-text-change This change requires some careful wording. feature/rewards labels Dec 9, 2019
@NejcZdovc NejcZdovc added this to the 1.4.x - Nightly milestone Dec 9, 2019
@NejcZdovc NejcZdovc self-assigned this Dec 9, 2019
@NejcZdovc NejcZdovc mentioned this issue Dec 9, 2019
Merged
32 tasks
@NejcZdovc NejcZdovc added QA/Yes and removed needs-text-change This change requires some careful wording. labels Dec 9, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 9, 2019
@NejcZdovc
Adds up to to AC settings page
fde3901 
Resolves brave/brave-browser#7277
@kjozwiak kjozwiak mentioned this issue Dec 19, 2019
Closed
35 tasks
@kjozwiak kjozwiak modified the milestones: 1.4.x - Dev, 1.3.x - Beta Jan 2, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Jan 7, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)

Screen Shot 2020-01-07 at 10 37 21 AM

Screen Shot 2020-01-07 at 10 37 31 AM

Verification passed on

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging a pull request may close this issue.

Adds up to to AC settings page brave/brave-core
5 participants
@kjozwiak @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya