Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twitch Video's doesn't play in Brave #760

Closed
GeetaSarvadnya opened this issue Aug 17, 2018 · 2 comments · Fixed by brave/brave-core#349
Closed

Twitch Video's doesn't play in Brave #760

GeetaSarvadnya opened this issue Aug 17, 2018 · 2 comments · Fixed by brave/brave-core#349
Labels
bug feature/shields/adblock Blocking ads & trackers with Shields QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 17, 2018 •
edited
Loading

Description

Twitch Video's doesn't play in Brave, due to Ad blocker issue. If we select Allow Ads and tracking in Shield, the videos are playing. Also when you turn down the Shield settings, the videos are playing.

Steps to Reproduce

  1. Launch Brave with Fresh profile
  2. Open Twitch videos

Actual result:

Twitch Video's doesn't play in Brave. Throwing console error
twitch videos doesn t play in brave core

Expected result:

Twitch videos should play

Reproduces how often:

100%

Brave version (about:brave info)

Version 0.54.0 Chromium: 69.0.3497.32 (Official Build) dev (64-bit)

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? - Yes
  • Is the issue reproducible on the latest version of Chrome? - No

Additional Information

cc: @bbondy
@GeetaSarvadnya GeetaSarvadnya added this to the Backlog milestone Aug 17, 2018
@GeetaSarvadnya GeetaSarvadnya changed the title Twitch Video's doesn't play in Brave Core. Twitch Video's doesn't play in Brave Aug 17, 2018
@srirambv srirambv modified the milestones: Backlog, Releasable builds 0.55.x Aug 17, 2018
bbondy added a commit to brave/brave-core that referenced this issue Aug 21, 2018
@bbondy
Update ad-block lib for Twitch fix
42f8ec2 
Mainly when no filter option was specified we were matching rule types that weren't meant to be generic

Test exists in the ad-block repo

Fix brave/brave-browser#760
@bbondy bbondy mentioned this issue Aug 21, 2018
Merged
11 tasks
@bbondy bbondy added the QA/Yes label Aug 21, 2018
@bbondy
Copy link
Member

bbondy commented Aug 21, 2018

QA note: this will need a new adblock update but @emerick is doing one now.

emerick added a commit to emerick/vault-updater that referenced this issue Aug 21, 2018
@emerick
Bump Ad Block extensions to version 1.0.2
be8b498 
Incorporates fix for brave/brave-browser#760
@emerick emerick mentioned this issue Aug 21, 2018
Merged
emerick added a commit to emerick/vault-updater that referenced this issue Aug 21, 2018
@emerick
Bump Ad Block extensions to version 1.0.2
e92917c 
Incorporates fix for brave/brave-browser#760. Includes test to verify
that extensionManifest.json is well-formed.
@emerick emerick mentioned this issue Aug 21, 2018
Merged
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Aug 28, 2018 •
edited by srirambv
Loading

Verified on:

Brave 0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows

Verification Pass with

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

@bbondy bbondy added the QA/Yes label Sep 27, 2018
This was referenced Mar 8, 2019
Closed
Closed
This was referenced Mar 8, 2019
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Mar 8, 2019
Open
This was referenced Mar 8, 2019
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Mar 11, 2019
Closed
@kjozwiak kjozwiak mentioned this issue Mar 11, 2019
Closed
This was referenced Mar 11, 2019
Closed
Closed
@jasonrsadler jasonrsadler mentioned this issue Mar 12, 2019
Closed
@kjozwiak kjozwiak mentioned this issue Mar 12, 2019
Closed
6 tasks
@dminca dminca mentioned this issue Mar 12, 2019
Closed
This was referenced Mar 13, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Mar 13, 2019
Closed
This was referenced Mar 13, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@petemill petemill mentioned this issue Mar 13, 2019
Closed
This was referenced Mar 14, 2019
Closed
Closed
Closed
@dangh dangh mentioned this issue Mar 18, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feature/shields/adblock Blocking ads & trackers with Shields QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Update ad-block lib for Twitch fix brave/brave-core
4 participants
@bbondy @srirambv @LaurenWags @GeetaSarvadnya