Send platform, build channel, and country as part of ad confirmation calls where it meets privacy standards

[jsecretan]

Description

To enable better debugging on the ads system, we would like to include the build channel and platform in our confirmation requests.

To enable better ad reporting for clients, and where the data can still maintain very large anonymity sets (large countries) send the country of the client which triggered the ad. The pseudo-code contains a list of the countries which are large enough to meet privacy requirements.

confirmation_parameters.build_channel = build_channel
confirmation_parameters.platform = platform
if release channel and confirmation_parameters.country in ("US","FR","GB","CA","DE","IN","BR","PH","AU","NL","ES","PL","RU","VE","VN","MX","IT","JP","CH","BE","ID","RO","SE","MY","TR","AR","CO","PT","TH","UA","AT","KR","FI","PK","ZA","NO","DK","CZ","EG","BD","RS","DZ","PE","SG","GR","HU","NZ","CL","CN","IE","MA","BG","EC","IL","TW","SA","AE","HK","NG","HR","SI","SK","KE","MN","NP","TN","LT","IR","EE","GH","DO","LV","LK","BA","BY","GE","CR","BO","GT","IQ","UY","KZ","MK","PR","MD","PA","LU","QA","AL","JO","CY","KH","KW","IS","CI","SV","MT","TT","PS","HN","SN","JM","PY","LB","LY","MM","AZ","CM","NI","ZW","OM","AM","RE","UG","MU","TZ","UZ","BH","ME","MG","ET","BJ","AF","BN","BB","ZM","NA","CD","RW","BW","BS","KG") then
    confirmation_parameters.country = country
if publisher_channel is not null then
    confirmation_parameters.publisher_channel = publisher_channel

post_request.payload = confirmation_parameters
send_post(/v1/confirmation/{confirmationId}, post_request)

[jsecretan]

Actually, let's skip segments for now to simplify.

[tmancey]

#7817 (comment) to be added as apart of this ticket

[GeetaSarvadnya]

Verification passed on

Brave | 1.9.55 Chromium: 81.0.4044.129 (Official Build) dev (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

• Tested on staging environment. Charles proxy setup: Host: ads-serve.bravesoftware.com and Path: /v1/confirmation/*/*
• Verified the test plan from Send platform, build channel and country code as part of ad confirmation calls where it meets privacy standards brave-core#5067
• Verified that buildChannel and platform is shown in the Body:

Note: countryCode is shown only in the Release channel

[15220:17180:0505/155238.523:INFO:redeem_token.cc(110)] POST /v1/confirmation/{confirmation_id}/{credential}
[15220:17180:0505/155238.523:INFO:redeem_token.cc(113)] URL Request:
[15220:17180:0505/155238.523:INFO:redeem_token.cc(116)]   URL: https://ads-serve.bravesoftware.com/v1/confirmation/ea583e53-3fbe-4461-98db-2319dc6034d7/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwicEE1ZkU3eDVJRkwzY2toYXpDdmcwVU9MR25ocGljQm1xMThEUzk1anRoWT1cIixcImJ1aWxkQ2hhbm5lbFwiOlwiZGV2XCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcIjQ2NWUwOGFkLTAzYmUtNDJlZS05MDJhLWRjODg2ODhhYTJjYlwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcIndpbmRvd3NcIixcInR5cGVcIjpcInZpZXdcIn0iLCJzaWduYXR1cmUiOiJhODVqS2hidFE0cTJzYjBUS0dZT3hFelhvUTg4cWVkbnpqamhaZWNNQjlqUGNTVE1vd2VCWFRVeHQ2bmJENktmOHduMG4xOHE3OWFQVS9HR1dCZDhlUT09IiwidCI6Iitycm1QMFN3S0hmeUV3UTFpb2VIRTJYRnRFL2dPT2NtMmlNU1N4N29DdHRuZ2djTVN6SzBrbG56bWExTThjRlg1bElDZjFVQ1hHVTNwOGZ0M1lRN1l3PT0ifQ==
[15220:17180:0505/155238.524:INFO:redeem_token.cc(128)]   Body: {"blindedPaymentToken":"pA5fE7x5IFL3ckhazCvg0UOLGnhpicBmq18DS95jthY=","buildChannel":"dev","creativeInstanceId":"465e08ad-03be-42ee-902a-dc88688aa2cb","payload":{},"platform":"windows","type":"view"}

Verification passed on

Brave	1.9.62 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS	Ubuntu 18.04 LTS

• Verified the test plan from Send platform, build channel and country code as part of ad confirmation calls where it meets privacy standards brave-core#5067
• Verified that buildChannel and platform is shown in the Body:

[8261:8261:0512/045302.720453:INFO:redeem_token.cc(128)]   Body: {"blindedPaymentToken":"gLy39XxVZ7P4cSHkq4M4hwpaILSkI3pOh2z86QjcsX0=","buildChannel":"dev","creativeInstanceId":"0d87dd71-eca5-4691-9dbc-fa7eeb9580db","payload":{},"platform":"linux","type":"landed"}

---

Verified passed with

Brave | 1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

• Verified test plan from Send platform, build channel and country code as part of ad confirmation calls where it meets privacy standards brave-core#5067

• buildChannel and platform are displayed:

[15741:775:0518/084541.203144:INFO:redeem_token.cc(108)] CreateConfirmation
[15741:775:0518/084541.203173:INFO:redeem_token.cc(110)] POST /v1/confirmation/{confirmation_id}/{credential}
[15741:775:0518/084541.203189:INFO:redeem_token.cc(113)] URL Request:
[15741:775:0518/084541.203208:INFO:redeem_token.cc(116)]   URL: https://ads-serve.brave.com/v1/confirmation/9330bfb8-0186-4884-864c-4aedf1cd4cab/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiMXFBR1FWMXoyZSt2U2VRR0NjUTdOQk5WaTk3enJkRkhMc1loWHJzRXVudz1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCI4NGViMjc4NS05ZGViLTRhMmEtYTFjYS1mZjZjMjU3NzY4NWVcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJtYWNvc1wiLFwidHlwZVwiOlwiZGlzbWlzc1wifSIsInNpZ25hdHVyZSI6IlRCN0FucEdyT09UYk5NcFBjUUdvblNWT01xRVZuWG1wTFBxRVZKUkg5R0V0TW5vUWx2MDJQNmtSQ2V4Z2R6elJacUZEcWY1cUR3dkJUMllZbFRUeHFRPT0iLCJ0IjoiWjkrU1ZvMTU2OWE2ekdrSU9JMUdPVXBDWFFmUWVCVTB5MDJEU29FRkJNRWx5Zmk5OTJXNnJmTmx2YkVucU16TEZPeUJBZWhmZlJoUkF2WVB5bUg5Y3c9PSJ9
[15741:775:0518/084541.203456:INFO:redeem_token.cc(128)]   Body: {"blindedPaymentToken":"1qAGQV1z2e+vSeQGCcQ7NBNVi97zrdFHLsYhXrsEunw=","buildChannel":"release","creativeInstanceId":"84eb2785-9deb-4a2a-a1ca-ff6c2577685e","payload":{},"platform":"macos","type":"dismiss"}

• Logged follow up issue for countryCode not being displayed: Country not part of ad confirmation call - follow up to #8100 #9823