Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Don't ask me again" pref to 404 Wayback machine infobar #8497

Closed
rebron opened this issue Mar 3, 2020 · 9 comments · Fixed by brave/brave-core#9030
Closed

Add "Don't ask me again" pref to 404 Wayback machine infobar #8497

rebron opened this issue Mar 3, 2020 · 9 comments · Fixed by brave/brave-core#9030
Labels
design A design change, especially one which needs input from the design team feature/wayback machine OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 3, 2020

Description

For those users who don't want to see the 404 Wayback machine notification, provide a way to disable the notification without having to go to brave://settings/braveHelpTips.

Setting "Don't ask me again" should toggle 'Show Wayback Machine prompt on 404 pages' setting.

Steps to Reproduce

  1. Visit https://www.brave.com/bo
  2. Notice 404 infobar prompt.
  3. Need to provide a way to not show prompt again in context.

Designs:

[placeholder]

@rebron rebron added feature/wayback machine design A design change, especially one which needs input from the design team labels Mar 3, 2020
@PierBover
Copy link

Please yes... this Wayback Machine integration is super annoying.

@yippie
Copy link

yippie commented Apr 8, 2020

Even worse, it seems to show up when a single resource used by the page 404s

Go to https://mdcoverage.secure.force.com/docs/metadata-coverage

notice the page loads completely and correctly but you STILL GET THE BANNER.

@rebron
Copy link
Collaborator Author

rebron commented Apr 8, 2020

@yippie Via devtools console, it looks like something did 404 https://mdcoverage.secure.force.com/docs/metadata-coverage/48
We'll look into not showing the prompt if the main resource is loading properly.

@bsclifton
Copy link
Member

@yippie that page is trying to redirect to https://mdcoverage.secure.force.com/docs/metadata-coverage/48 which network shows a 404 received. Brave has no way to tell if the content actually loaded, only what HTTP status code was returned. This feature can be turned off on brave://settings/braveHelpTips

Screen Shot 2020-04-08 at 9 37 44 AM
Just turn it off there and you'll never see it again 😄

@yippie
Copy link

yippie commented Apr 9, 2020

Oh thank you! turned it off because the Wayback has proven completely worthless for me. I have never encountered a situation where it would actually work. I have only ever gotten it in two ways:

  • A resource, but not the main page, threw a 404 <- this was super annoying
  • I was trying to access an authenticated page after my session expired. Wayback would obviously not help there.

@bsclifton
Copy link
Member

@yippie you're welcome 😄

cc: @rebron for feedback!

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Apr 17, 2020
@kjozwiak
Copy link
Member

https://www.reddit.com/r/brave_browser/comments/g3y1iw/wayback_machine_in_private_mode_with_tor/fnvorf9?utm_source=share&utm_medium=web2x

Another example of users having a hard time finding the setting that disables this feature.

@stephendonner
Copy link

Verified PASSED using the testplan from brave/brave-core#9030 with build

Brave 1.27.62 Chromium: 91.0.4472.101 (Official Build) nightly (x86_64)
Revision af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS macOS Version 11.4 (Build 20F71)

Scenario 1: Don't ask me again button

Steps:

  1. new profile
  2. loaded brave://settings/braveHelpTips
  3. confirmed Show Wayback Machine prompt on 404 pages was toggled by default to On
  4. loaded brave.com/bad-link and confirmed I got the Wayback Machine prompt
  5. clicked the Don't ask me again button
  6. confirmed the pref toggled back to Off
  7. reloaded brave.com/bad-link and confirmed I no longer got the Wayback Machine infobar
example example example example
Screen Shot 2021-06-14 at 12 55 30 PM Screen Shot 2021-06-14 at 12 57 01 PM Screen Shot 2021-06-14 at 12 57 15 PM Screen Shot 2021-06-14 at 12 59 09 PM

Scenario 2: Check for Saved Version button

Steps:

  1. new profile
  2. loaded brave://settings/braveHelpTips
  3. confirmed Show Wayback Machine prompt on 404 pages was toggled by default to On
  4. loaded brave.com/bad-link and confirmed I got the Wayback Machine prompt
  5. clicked on Check for saved version
  6. confirmed it checked for a saved version and printed out Sorry, there is no saved version available in the infobar
example example example
Screen Shot 2021-06-14 at 12 55 30 PM Screen Shot 2021-06-14 at 12 57 15 PM Screen Shot 2021-06-14 at 1 29 12 PM

@rebron
Copy link
Collaborator Author

rebron commented Jun 17, 2021

Thanks @rahulsnkr nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/wayback machine OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants