[Desktop] "Undo" delete of a top site tile does not restore the tile to its previous position #9457

LaurenWags · 2020-04-24T19:57:42Z

Test plan

Description

Found while testing #2971

In 1.7.x version if you delete a tile (by clicking on the x) and then select Undo on the modal, the deleted top site tile is restored to its previous position.

If you do this on 1.8.x, the restored tile jumps to the first non-pinned position.

Steps to Reproduce

Have a profile with history and top site tiles (enough history so that if you remove a tile you have a site to take its place) - doesn't matter if it's clean or upgrade profile.
Have a couple sites pinned (my 1st and 4th tiles are pinned).
Delete a tile, such as the 5th one.
On the modal, click Undo.

Actual result:

Restored top site tile jumps to the first unpinned position (in this case, the 2nd place).

Expected result:

Tile is restored to its former position/place as it is in 1.7.x.

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision	e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS	macOS Version 10.14.6 (Build 18G3020)

Brave	1.10.9 Chromium: 81.0.4044.122 (Official Build) nightly (64-bit)
Revision	44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS	macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

Can you reproduce this issue with the current release? not on 1.7.x
Can you reproduce this issue with the beta channel? yes
Can you reproduce this issue with the dev channel? yes
Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @rebron @cezaraugusto @bsclifton

The text was updated successfully, but these errors were encountered:

- Move gridSiteState to sessionStorage (not localStorage) and default value for "use custom links". Includes cleanup of previous localStorage value (if user has one). sessionStorage seems to be persisted between tabs and should be cleaned up when browser is closed. - X to remove tiles is now right aligned - Update top sites mode/visible setting when NTP gets updates - Fixed disabled icon showing when tiles are movable (condition was reversed) - Title case the new preference (to match existing preference) And of course, closing keywords for this PR: Fixes brave/brave-browser#11500 Fixes brave/brave-browser#9788 Fixes brave/brave-browser#9457 Fixes brave/brave-browser#11551

GeetaSarvadnya · 2020-10-19T17:10:41Z

Verification is passed on

Brave | 1.17.39 Chromium: 86.0.4240.99 (Official Build) nightly (64-bit)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | Windows 10 OS Version 1903 (Build 18362.1082)

Verified the test plan from Make top sites work like Chromium brave-core#6584
Logged Top sites are not re-added once all the top sites are removed #12378

Verify top site tiles are added

Verified that visited sites are added as top tiles in a new tab
Verified that the order of top tiles is matching the order of visited sites

Re-ordering top site tiles

Verified that Re-ordering the top tiles in a new window are retained in the original window
Verified that top tiles order matches on both windows
Closed and re-opened browser and verified that the order of the top tiles is not changed in both windows
Visited more sites on both windows and verified that the order of top tiles is not changed

Removing sites and Most Visited mode

Verified that removed top tiles didn't come back after the browser restart
Verified that Top sites are in Most visited mode when the Customize top sites setting is disabled
Verified that Top sites CAN NOT be re-ordered when Customize top sites settings is disabled
Verified that top sites can be removed when Customize top sites settings is disabled
Verified that top sites can be restored when Customize top sites settings is disabled
Disabled and enabled other settings from customize dashboard and ensured that all the settings are working as expected.

Removing and restoring

Verified undo option is shown when one top site is removed from the top tiles
Verified undo option is shown when two or multiple top sites are removed from NTP
Verified Restore all option is shown when a site is removed
Verified all sites are restored after clicking on the Restore all option
Verified that restored sites are retained when the browser is restarted

Super Referral behavior

Verified that SR top sites are shown in NTP's for SR profile
Verified that super referral top tiles cannot be moved or deleted
Visited few websites and ensured that non-SR top tiles are added in NTP's
Verified that non-SR top tiles can be removed/Undo/Restore All
After adding non-SR top tiles restarted the browser and ensured top tiles are retained in NTP's
Disabled SR images via Theme settings and ensured SR top tiles are disappeared from NTP's

Verified passed with

Brave	1.17.69 Chromium: 87.0.4280.60 (Official Build) (x86_64)
Revision	12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS	macOS Version 10.14.6 (Build 18G6042)

Verified test plan from brave/brave-core#6584

Verify top site tiles are added

Confirmed top site tiles are added to NTP:

Confirmed first 6 top site tiles on NTP match brave://new-tab-page:

Reordering Top Site tiles

Reordered top site tiles on NTP:

Confirmed reorder matches on brave://new-tab-page:

Closed/relaunched. Confirmed order on Brave NTP and brave://new-tab-page was retained on relaunch.

Visited additional sites. Confirmed sites are not moved around after re-ordering.

Removing sites and Most Visited mode

Removed some top site tiles from NTP:

Closed/relaunched. Confirmed confirmed removed sites were not re-added.

Disabled Customize top sites:

Confirmed NTP top site tiles changed:

Confirmed unable to re-order the top site tiles after disabling this setting.

Removing and Restoring

Confirmed top site tiles are added to NTP:

Removed a tile:

Undo notice:

Confirmed site is added back:

Removed two tiles:

Selected Restore All:

Confirmed all sites restored:

Super Referral behavior

SR NTP:

SR NTP Top Site Tiles:

Confirmed SR NTP top site tiles cannot be moved, unable to drag and drop to a new place.
Confirmed SR NTP top site tiles cannot be deleted, hovering over a top site tile does not show the "x" for removal.

Visited a few websites, open top site tile spots were populated with sites visited:

Confirmed able to move the non SR top site tiles:

Confirmed able to remove non SR top site tiles:

Confirmed able to restore non SR top site tiles:

Confirmed able to disable SR theme in brave://settings/themes:

Confirmed SR top site tiles are removed and the tiles for the sites I visited are shown:

Upgrade - no top site tile modification in 1.16.x

Installed 1.16.x
Visited 6+ sites
Confirmed top site tiles were populated on NTP:

Updated to 1.17.
Confirmed top site tiles still populated on NTP as expected:

Confirmed able to move/delete top site tiles post upgrade:

Confirmed close/relaunch, modifications were retained.

Upgrade - top site tile modifications made with 1.16.x

Installed 1.16.x
Visited 6+ sites
Confirmed top site tiles were populated on NTP. Re-ordered/deleted some top site tiles:

Updated to 1.17.
Modifications to tiles are lost (expected):

Note, for the STR in the description there is no more pinning top site tiles with 1.17.x. Additionally, modifications to top site tiles made with 1.16.x (and before) are not retained when upgrading to 1.17.x. Modified STR to check Undo restoring a tile was confirmed as per the above in "Removing and Restoring" case.

LaurenWags added feature/new-tab QA/Yes OS/Desktop regression labels Apr 24, 2020

LaurenWags mentioned this issue Apr 28, 2020

refactor new tab top sites #2971

Closed

rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Jun 5, 2020

This was referenced Sep 4, 2020

[Desktop] Top sites on New Tab Page are missing #11500

Closed

Make top sites work like Chromium brave/brave-core#6584

Merged

srirambv changed the title ~~"Undo" delete of a top site tile does not restore the tile to its previous position~~ [Desktop] "Undo" delete of a top site tile does not restore the tile to its previous position Sep 9, 2020

bsclifton self-assigned this Sep 10, 2020

bsclifton added QA/Test-Plan-Specified release-notes/include labels Sep 10, 2020

bsclifton closed this as completed in brave/brave-core#6584 Oct 7, 2020

bsclifton added this to the 1.17.x - Nightly milestone Oct 7, 2020

GeetaSarvadnya added the QA Pass-Win64 label Oct 27, 2020

LaurenWags added the QA Pass-macOS label Nov 17, 2020

This was referenced Nov 17, 2020

Top/Pinned Sites Can't be Removed (Reappear after refresh) #9788

Closed

[Desktop] Top site behavior seems wrong / unpredictable #11551

Closed

[Desktop] Release Notes for 1.17.x Release #2 (Release Channel) #12771

Closed

LaurenWags added release-notes/exclude and removed release-notes/include labels Nov 18, 2020

LaurenWags mentioned this issue Nov 18, 2020

[Desktop] Improved top site tiles on the New Tab Page #12772

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Desktop] "Undo" delete of a top site tile does not restore the tile to its previous position #9457

[Desktop] "Undo" delete of a top site tile does not restore the tile to its previous position #9457

LaurenWags commented Apr 24, 2020 •

edited by bsclifton

Loading

GeetaSarvadnya commented Oct 19, 2020 •

edited by LaurenWags

Loading

[Desktop] "Undo" delete of a top site tile does not restore the tile to its previous position #9457

[Desktop] "Undo" delete of a top site tile does not restore the tile to its previous position #9457

Comments

LaurenWags commented Apr 24, 2020 • edited by bsclifton Loading

Test plan

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

GeetaSarvadnya commented Oct 19, 2020 • edited by LaurenWags Loading

LaurenWags commented Apr 24, 2020 •

edited by bsclifton

Loading

GeetaSarvadnya commented Oct 19, 2020 •

edited by LaurenWags

Loading