Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Github publishers do not show 'on GitHub' on Rewards panel #9696

Open
LaurenWags opened this issue May 8, 2020 · 5 comments
Open
Assignees
Labels
ARM Android ARM related issues bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes

Comments

@LaurenWags
Copy link
Member

LaurenWags commented May 8, 2020

Description

On desktop when you visit a github page/profile and open the Rewards panel it says "someuser on GitHub". Android doesn't show the "on GitHub" part.

Steps to reproduce

  1. Have Rewards enabled
  2. Navigate to a page like github.com/laurenwags (doesn't matter if the publisher is verified or not)
  3. Open panel

Actual result

no 'on GitHub'
android-GH

Expected result

should show 'on GitHub' as desktop does
Screen Shot 2020-05-08 at 4 17 08 PM

Issue reproduces how often

easily

Issue happens on

  • Current Play Store version? yes
  • Beta build? yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): all
  • Android version: all

Brave version

1.8.93 (Beta), 1.10.39 (Nightly), 1.7.102 (Release)

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 24, 2022

solved in 1.35 new panel

@Miyayes Miyayes closed this as completed Jan 24, 2022
@LaurenWags
Copy link
Member Author

@Miyayes this still reproduces on 1.36.x Nightly

Screenshot_20220124-155039

@LaurenWags LaurenWags reopened this Jan 24, 2022
@zenparsing zenparsing added the priority/P4 Planned work. We expect to get to it "soon". label Jan 26, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented May 17, 2023

@GeetaSarvadnya Will check.

@GeetaSarvadnya
Copy link

@Miyayes The issue is NOT reproducible anymore. It's behaving same as Desktop. Verified on Vivo x70 Pro version 12 running Bravemonoarm64.apk_1.51.114

Desktop Android
image Screenshot_20230517_213739

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2023
@LaurenWags
Copy link
Member Author

@GeetaSarvadnya you visited laurenwags.github.io not github.com/laurenwags (or similar page). Can you try with visiting a page like github.com/laurenwags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM Android ARM related issues bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Projects
None yet
Development

No branches or pull requests

6 participants