Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Claim notification is not closed even when claim itself is already received #9833

Closed
samartnik opened this issue May 19, 2020 · 1 comment · Fixed by brave/brave-core#5589

Comments

@samartnik
Copy link
Contributor

Description

Claim notification is not closed even when claim itself is already received. Issues started after this change brave/brave-core#5520

Steps to reproduce

  1. Click claim from panel
  2. Infinite spinner is running and notification is not closed

Actual result

Infinite spinner is running and notification is not closed

Expected result

Claim notification is closed, once claim is received

Issue reproduces how often

Issue happens on

  • Current Play Store version? no
  • Beta build? no

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.10.x

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@btlechowski
Copy link

btlechowski commented Jun 17, 2020

Verification passed on BraveModernarm v1.10.92 on Samsung Galaxy Tab S5e (Android 9.0)

Verified test plan from the description.
Verified Grant notification is no longer shown after claim was successful
Verified there is no infinite spinner after claiming a grant

Verification passed on Samsung Galaxy J3 version 5.1.1 running BraveModernarm 1.10.92.apk

  • Verified test plan from the description.
  • Verified Grant notification is no longer shown after the claim was successful
  • Verified there is no infinite spinner after claiming a grant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants