-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearing "History" doesn't remove "Top Sites" on the new tab page #9929
Comments
This is still not fixed in: Can we at least warn users we are not respecting their privacy until a fix can be put in, or ideally remove top sites until it can be implemented with the users privacy settings in mind? |
This might actually be fixed in the latest update. I've not managed to recreate this issue today on: |
cc: @rebron - we probably should make it visible on the |
@BrendanEich can we please, as a stop gap, warn people that wiping their history is not wiping everything? |
someone posted this issue on hacker news |
NTP gets topsites data from browser's history and manages them(site url, favicon cache url and etc...) to its own place(localStorage) in here. |
I'm trying to fix this by clearing topsites data implicitely when user clears history. WDYT? @rebron @bsclifton |
@simonhong that should work perfectly. We will allow those to be edited (we have an issue for it), but at the moment it's tied directly to history (only real action you can do is move, pin, and close) Marked as P2 since there is a leak (localStorage) |
@bsclifton Ok. Working on it :) |
As a user, I’m now concerned that there are other places where urls and/or history are kept. |
@Joshfindit top sites should be the only place where we stored URLs - which with localStorage it would be tied to the Brave extension's localStorage. Clearing cookies should be clearing it - but the problem is if you pick clear history, this should be wiped too There aren't any other areas we're aware of- but might be good to do an audit |
Yes please fix this. My student seen the pornhub icon on top sites. |
It was just a joke. At least, i imagine people complaining about this issue because of porn website in top sites :D |
Verification passed on
Scenario 1:
Scenario 2: - launch profile with SR code Verification passed on
Scenario 1:
Scenario 2: - launch profile with SR code Verified passed with
Verified plan 1 from https://github.com/brave/brave-core/pull/6047Step 2 - top site tiles populated: Step 4 - after one site is removed from history, confirmed it is not shown in top site tiles any more: Step 5 - pinned one top site tile: Step 7 - after the pinned site is removed from history, confirmed it is not shown in top site tiles any more: Step 9 - confirmed all top site tiles are removed Additionally:
Verified plan 2 from https://github.com/brave/brave-core/pull/6047Confirmed SR install (used TECHNIK) top site tiles are populated without any history: |
Version 1.9.72 Chromium: 81.0.4044.138 (Official Build) (64-bit)
The text was updated successfully, but these errors were encountered: