added ipfs to crx packaging files #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ this was on my list soon to post an issue for |
|
@emerick can you own this, I think we'll need to have our own keys that we manage in the same way though |
|
Sure thing! |
|
@emerick let me know if there is any help I can provide! |
lidel
reviewed
Sep 6, 2018
| @@ -30,6 +30,7 @@ | |||
| "package-https-everywhere": "node ./scripts/packageComponent --type https-everywhere-updater", | |||
| "package-themes": "node ./scripts/packageThemes", | |||
| "package-tor-client": "node ./scripts/packageTorClient", | |||
| "package-ipfs-daemon": "node ./scripts/packageIpfsDaemon", | |||
| mkdirp.sync(ipfsPath) | ||
| const ipfsDaemon = path.join(ipfsPath, ipfsFilename) | ||
| // Build decompression command based on system | ||
| const decompressUnix = ' | tar xf - -C ' + ipfsPath + ' && cp ' + ipfsPath + '/go-ipfs/ipfs ' + ipfsDaemon |
There was a problem hiding this comment.
Does this work without z?
On Linux I had to use tar xzf - -C to make it work.
|
Carried over to #23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding files to package go-ipfs as a brave-core-crx, similar to the Tor crx implementation
What is needed to manage the IPFS binary from the brave-core C++ side?
I see a PR here that seems to have those controls for Tor brave/brave-core@ed7c0ab
@lidel @emerick @bsclifton @darkdh