Skip to content

Commit

Permalink
Update private/tor label in profile menu view
Browse files Browse the repository at this point in the history
  • Loading branch information
simonhong committed Nov 18, 2020
1 parent cec28dd commit 0824a0c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 5 deletions.
12 changes: 9 additions & 3 deletions app/brave_generated_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -308,10 +308,16 @@ By installing this extension, you are agreeing to the Google Widevine Terms of U
New Tor Connection For This Site
</message>
<message name="IDS_PROFILES_EXIT_TOR" desc="Button in the avatar menu bubble view for exiting the active Tor session.">
Exit Tor
Exit Private Window with Tor
</message>
<message name="IDS_PROFILES_EXIT_PRIVATE" desc="Button in the avatar menu bubble view for closing private window.">
Exit Private Window
</message>
<message name="IDS_TOR_PROFILE_NAME" desc="The name given to the Tor browsing profile. Displayed in the avatar menu bubble and button UI.">
Tor
Private Window with Tor
</message>
<message name="IDS_PRIVATE_PROFILE_NAME" desc="The name given to the private profile. Displayed in the avatar menu bubble and button UI.">
Private Window
</message>
<message name="IDS_TOR_AVATAR_BUTTON_LABEL" desc="The text label of tor avatar button.">
Private with Tor
Expand All @@ -320,7 +326,7 @@ By installing this extension, you are agreeing to the Google Widevine Terms of U
This is private window with tor
</message>
<message name="IDS_PROFILES_OPEN_TOR_PROFILE_BUTTON" desc="Button in the avatar menu bubble view to open a Tor window.">
Open Tor Window
Open Private Window with Tor
</message>
<message name="IDS_LOCATION_BAR_OPEN_IN_TOR" desc="Button in location bar to open onion available site in tor window.">
Open in Tor
Expand Down
4 changes: 2 additions & 2 deletions browser/ui/views/profiles/brave_incognito_menu_view.cc
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,12 @@ bool ShouldShowTorProfileButton(Profile* profile) {

int GetProfileMenuTitleId(Profile* profile) {
return brave::IsTorProfile(profile) ? IDS_TOR_PROFILE_NAME
: IDS_INCOGNITO_PROFILE_MENU_TITLE;
: IDS_PRIVATE_PROFILE_NAME;
}

int GetProfileMenuCloseButtonTextId(Profile* profile) {
return brave::IsTorProfile(profile) ? IDS_PROFILES_EXIT_TOR
: IDS_INCOGNITO_PROFILE_MENU_CLOSE_BUTTON;
: IDS_PROFILES_EXIT_PRIVATE;
}

int GetWindowCount(Profile* profile) {
Expand Down

0 comments on commit 0824a0c

Please sign in to comment.