Add provider to tip compliment

[jdkuki]

Fixes brave/brave-browser#4586

Added publisher provider to tweetTip compliment string displayed when sharing a tip via tweet.
Compliment string now reads "I just tipped [publisher] on [provider]"

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Windows
  • macOS
  • Linux
• Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
  • Windows
  • macOS
  • Linux
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

See steps at brave/brave-browser#4586

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[jdkuki]

tweet_id should be allowed to be empty so removed equivalent check used in old API

[NejcZdovc]

why should be allowed to be empty?

[jdkuki]

It appears that tweet_id is given as empty in:

brave-core/components/brave_rewards/resources/tip/components/tipSite.tsx

Lines 21 to 37 in 90b3163

	class TipSite extends React.Component<Props, {}> {
	get actions () {
	return this.props.actions
	}
	onTweet = () => {
	let name = this.props.publisher.name
	if (this.props.publisher.provider === 'twitter') {
	const url = this.props.url
	if (url && url.length > 0) {
	name = `@${url.replace(/^.*\/(.*)$/, '$1')}`
	}
	}
	this.actions.onTweet(name, '')
	this.actions.onCloseDialog()
	}

I believe the field may be used in the case of a twitter tip to attach the complement as a reply (may be completely wrong) and is not applicable in the case where we tip a site?

[jdkuki]

tipSite.tsx:35 updated below

[jdkuki]

Requires proper formatting, @NejcZdovc will suggest fix

[NejcZdovc]

closing as stale, let's revisit when needed