modified output name to 'brave', fixed symbols for on linux build #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
approved these changes
Dec 12, 2017
bbondy
force-pushed
the
shields
branch
2 times, most recently
from
c27ecc9
to
16d5d5a
Compare
ryanml
added a commit
that referenced
this pull request
Apr 8, 2019
Adds functionality to monthly contribution dropdown (Panel, #3 origin)
mkarolin
added a commit
that referenced
this pull request
Sep 25, 2019
Chromium changes: https://chromium.googlesource.com/chromium/src/+/26e73cfd90affbf1bdf3efbe80bf2903b0e866ae commit 26e73cfd90affbf1bdf3efbe80bf2903b0e866ae Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Aug 6 02:38:13 2019 +0000 Stop giving WebSocketClient to WebSocket creation function Instead, give it as an argument of mojom.WebSocketHandshakeClient.OnConnectionEstablished. This is a follow up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1728917. Passing the mojo::InterfaceRequest<WebSocketClient> at OnConnectionEstablished is less error prone because 1) It is unable to bind the implementation before that, and 2) It is now clear that we should detect connection errors on |handshake_client| until the connection is established, and |client| after that. Bug: 989406, 967524 https://chromium.googlesource.com/chromium/src/+/1007403a797957b8af46e962cdfc1f6f671954a4 commit 1007403a797957b8af46e962cdfc1f6f671954a4 Author: Yoichi Osato <yoichio@chromium.org> Date: Thu Aug 8 13:11:57 2019 +0000 [WebSocket] Use Datapipe to transfer DataFrame buffer instead of ReadOnlyBuffer This CL introduces mojo DataPipe instead of ReadOnlyBuffer. With DataPipe, we can reduce memory copy and optimize quota control. Unfortunately, this CL makes performance slower: ToT: 147 MB/s Patch: 128 MB/s That's because this CL replaces minimize part and we will do the optimization later on. If the optimization doesn't go over the original score before M78 (will be branch cut on Sep 5th), we will revert this change. Bug: 865001 https://chromium.googlesource.com/chromium/src/+/fcaa2a2c441e28a5cb95cc90946712efb0ce085f commit fcaa2a2c441e28a5cb95cc90946712efb0ce085f Author: Yoichi Osato <yoichio@chromium.org> Date: Wed Aug 28 08:22:36 2019 +0000 [WebSocket] Remove manual quota control for receiving. Because we're using mojo data pipe, which has own quota control, to transfer received data, we don't have manual one, or mojom::WebSocket.AddReceiveFlowControlQuota(). This CL does a sort of work removing the function. mojom::WebSocket.AddReceiveFlowControlQuota(quota) did 5 tasks: browser side(mainly on WebSocketChannel) 1. Trigger the first ReadFrame if renderer gets not throttled. For #1, this patch moves the trigger to mojo WebSocket.StartReceiving. 2. Trigger next ReadFrame if there is enough quota. 3. Send pending dataframes based on added quota. This patch moves task #2 and #3 to websocket.cc and datapipe itself. 4. Dropchannel if all pending frames are received by renderer when closed. Because we can care #4 w/o renderer ping back, this patch move RespondToClosingHandshake()to WebSocketChannel::ReadFrames(). renderer side(mainly on WebSocketChannelImpl) 5. Ping browser that backpressure is turned off. For task #5, this patch changes not to call the mojo but throttle datapipe reading with WebSocketHandleImpl::ConsumePendingDataFrames(). receive-arraybuffer-1MBx100.htmll?iteration=100 measurement on local build: ToT: 144 MB/s (stdev: 4.56 MB/s) Patch: 208 MB/s (stdev: 6.15 MB/s) (+44% to ToT, +41% to ReadOnlyBuffer) ReadOnlyBuffer: 147 MB/s https://chromium.googlesource.com/chromium/src/+/a461132e64f53f45997aaa4222e05cdf5d10ea56 commit a461132e64f53f45997aaa4222e05cdf5d10ea56 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Fri Aug 30 04:13:36 2019 +0000 Reland "Convert WebSocket to new Mojo types" This is a reland of 06a7200b370f38f39c97a4810d0931ab5596014e It updates WebSocketChannelImplTest::EstablishConnection with new Mojo types without InterfacePtr and MakeRequest. TBR=jam@chromium.org Original change's description: > Convert WebSocket to new Mojo types > > This CL converts WebSocketPtr, to new Mojo types and > updates OnConnectionEstablished from websocket.mojom. > > Bug: 955171, 978694 > Change-Id: I82416b209e2380241b64ebd3d829dd8bde5247c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773016 > Commit-Queue: Julie Kim <jkim@igalia.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#691574} Bug: 955171, 978694
mkarolin
added a commit
that referenced
this pull request
Oct 3, 2019
Chromium changes: https://chromium.googlesource.com/chromium/src/+/26e73cfd90affbf1bdf3efbe80bf2903b0e866ae commit 26e73cfd90affbf1bdf3efbe80bf2903b0e866ae Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Aug 6 02:38:13 2019 +0000 Stop giving WebSocketClient to WebSocket creation function Instead, give it as an argument of mojom.WebSocketHandshakeClient.OnConnectionEstablished. This is a follow up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1728917. Passing the mojo::InterfaceRequest<WebSocketClient> at OnConnectionEstablished is less error prone because 1) It is unable to bind the implementation before that, and 2) It is now clear that we should detect connection errors on |handshake_client| until the connection is established, and |client| after that. Bug: 989406, 967524 https://chromium.googlesource.com/chromium/src/+/1007403a797957b8af46e962cdfc1f6f671954a4 commit 1007403a797957b8af46e962cdfc1f6f671954a4 Author: Yoichi Osato <yoichio@chromium.org> Date: Thu Aug 8 13:11:57 2019 +0000 [WebSocket] Use Datapipe to transfer DataFrame buffer instead of ReadOnlyBuffer This CL introduces mojo DataPipe instead of ReadOnlyBuffer. With DataPipe, we can reduce memory copy and optimize quota control. Unfortunately, this CL makes performance slower: ToT: 147 MB/s Patch: 128 MB/s That's because this CL replaces minimize part and we will do the optimization later on. If the optimization doesn't go over the original score before M78 (will be branch cut on Sep 5th), we will revert this change. Bug: 865001 https://chromium.googlesource.com/chromium/src/+/fcaa2a2c441e28a5cb95cc90946712efb0ce085f commit fcaa2a2c441e28a5cb95cc90946712efb0ce085f Author: Yoichi Osato <yoichio@chromium.org> Date: Wed Aug 28 08:22:36 2019 +0000 [WebSocket] Remove manual quota control for receiving. Because we're using mojo data pipe, which has own quota control, to transfer received data, we don't have manual one, or mojom::WebSocket.AddReceiveFlowControlQuota(). This CL does a sort of work removing the function. mojom::WebSocket.AddReceiveFlowControlQuota(quota) did 5 tasks: browser side(mainly on WebSocketChannel) 1. Trigger the first ReadFrame if renderer gets not throttled. For #1, this patch moves the trigger to mojo WebSocket.StartReceiving. 2. Trigger next ReadFrame if there is enough quota. 3. Send pending dataframes based on added quota. This patch moves task #2 and #3 to websocket.cc and datapipe itself. 4. Dropchannel if all pending frames are received by renderer when closed. Because we can care #4 w/o renderer ping back, this patch move RespondToClosingHandshake()to WebSocketChannel::ReadFrames(). renderer side(mainly on WebSocketChannelImpl) 5. Ping browser that backpressure is turned off. For task #5, this patch changes not to call the mojo but throttle datapipe reading with WebSocketHandleImpl::ConsumePendingDataFrames(). receive-arraybuffer-1MBx100.htmll?iteration=100 measurement on local build: ToT: 144 MB/s (stdev: 4.56 MB/s) Patch: 208 MB/s (stdev: 6.15 MB/s) (+44% to ToT, +41% to ReadOnlyBuffer) ReadOnlyBuffer: 147 MB/s https://chromium.googlesource.com/chromium/src/+/a461132e64f53f45997aaa4222e05cdf5d10ea56 commit a461132e64f53f45997aaa4222e05cdf5d10ea56 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Fri Aug 30 04:13:36 2019 +0000 Reland "Convert WebSocket to new Mojo types" This is a reland of 06a7200b370f38f39c97a4810d0931ab5596014e It updates WebSocketChannelImplTest::EstablishConnection with new Mojo types without InterfacePtr and MakeRequest. TBR=jam@chromium.org Original change's description: > Convert WebSocket to new Mojo types > > This CL converts WebSocketPtr, to new Mojo types and > updates OnConnectionEstablished from websocket.mojom. > > Bug: 955171, 978694 > Change-Id: I82416b209e2380241b64ebd3d829dd8bde5247c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773016 > Commit-Queue: Julie Kim <jkim@igalia.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#691574} Bug: 955171, 978694
mkarolin
added a commit
that referenced
this pull request
Oct 3, 2019
Chromium changes: https://chromium.googlesource.com/chromium/src/+/26e73cfd90affbf1bdf3efbe80bf2903b0e866ae commit 26e73cfd90affbf1bdf3efbe80bf2903b0e866ae Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Aug 6 02:38:13 2019 +0000 Stop giving WebSocketClient to WebSocket creation function Instead, give it as an argument of mojom.WebSocketHandshakeClient.OnConnectionEstablished. This is a follow up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1728917. Passing the mojo::InterfaceRequest<WebSocketClient> at OnConnectionEstablished is less error prone because 1) It is unable to bind the implementation before that, and 2) It is now clear that we should detect connection errors on |handshake_client| until the connection is established, and |client| after that. Bug: 989406, 967524 https://chromium.googlesource.com/chromium/src/+/1007403a797957b8af46e962cdfc1f6f671954a4 commit 1007403a797957b8af46e962cdfc1f6f671954a4 Author: Yoichi Osato <yoichio@chromium.org> Date: Thu Aug 8 13:11:57 2019 +0000 [WebSocket] Use Datapipe to transfer DataFrame buffer instead of ReadOnlyBuffer This CL introduces mojo DataPipe instead of ReadOnlyBuffer. With DataPipe, we can reduce memory copy and optimize quota control. Unfortunately, this CL makes performance slower: ToT: 147 MB/s Patch: 128 MB/s That's because this CL replaces minimize part and we will do the optimization later on. If the optimization doesn't go over the original score before M78 (will be branch cut on Sep 5th), we will revert this change. Bug: 865001 https://chromium.googlesource.com/chromium/src/+/fcaa2a2c441e28a5cb95cc90946712efb0ce085f commit fcaa2a2c441e28a5cb95cc90946712efb0ce085f Author: Yoichi Osato <yoichio@chromium.org> Date: Wed Aug 28 08:22:36 2019 +0000 [WebSocket] Remove manual quota control for receiving. Because we're using mojo data pipe, which has own quota control, to transfer received data, we don't have manual one, or mojom::WebSocket.AddReceiveFlowControlQuota(). This CL does a sort of work removing the function. mojom::WebSocket.AddReceiveFlowControlQuota(quota) did 5 tasks: browser side(mainly on WebSocketChannel) 1. Trigger the first ReadFrame if renderer gets not throttled. For #1, this patch moves the trigger to mojo WebSocket.StartReceiving. 2. Trigger next ReadFrame if there is enough quota. 3. Send pending dataframes based on added quota. This patch moves task #2 and #3 to websocket.cc and datapipe itself. 4. Dropchannel if all pending frames are received by renderer when closed. Because we can care #4 w/o renderer ping back, this patch move RespondToClosingHandshake()to WebSocketChannel::ReadFrames(). renderer side(mainly on WebSocketChannelImpl) 5. Ping browser that backpressure is turned off. For task #5, this patch changes not to call the mojo but throttle datapipe reading with WebSocketHandleImpl::ConsumePendingDataFrames(). receive-arraybuffer-1MBx100.htmll?iteration=100 measurement on local build: ToT: 144 MB/s (stdev: 4.56 MB/s) Patch: 208 MB/s (stdev: 6.15 MB/s) (+44% to ToT, +41% to ReadOnlyBuffer) ReadOnlyBuffer: 147 MB/s https://chromium.googlesource.com/chromium/src/+/a461132e64f53f45997aaa4222e05cdf5d10ea56 commit a461132e64f53f45997aaa4222e05cdf5d10ea56 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Fri Aug 30 04:13:36 2019 +0000 Reland "Convert WebSocket to new Mojo types" This is a reland of 06a7200b370f38f39c97a4810d0931ab5596014e It updates WebSocketChannelImplTest::EstablishConnection with new Mojo types without InterfacePtr and MakeRequest. TBR=jam@chromium.org Original change's description: > Convert WebSocket to new Mojo types > > This CL converts WebSocketPtr, to new Mojo types and > updates OnConnectionEstablished from websocket.mojom. > > Bug: 955171, 978694 > Change-Id: I82416b209e2380241b64ebd3d829dd8bde5247c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773016 > Commit-Queue: Julie Kim <jkim@igalia.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#691574} Bug: 955171, 978694
LorenzoMinto
pushed a commit
that referenced
this pull request
Nov 10, 2022
# This is the 1st commit message: Add federated client to BraveFederated component # This is the commit message #2: Remove unnecessary files # This is the commit message #3: Hook up learning service # This is the commit message #4: Unlink client with DataStore # This is the commit message #5: comment # This is the commit message #6: temp # This is the commit message #7: todos # This is the commit message #8: Change to follow Chromium styleguide # This is the commit message #9: Refactor 1 # This is the commit message #10: Use grpc_support for comms
This was referenced Dec 6, 2022
LorenzoMinto
pushed a commit
that referenced
this pull request
Dec 12, 2022
# This is the 1st commit message: Add federated client to BraveFederated component # This is the commit message #2: Remove unnecessary files # This is the commit message #3: Hook up learning service # This is the commit message #4: Unlink client with DataStore # This is the commit message #5: comment # This is the commit message #6: temp # This is the commit message #7: todos # This is the commit message #8: Change to follow Chromium styleguide # This is the commit message #9: Refactor 1 # This is the commit message #10: Use grpc_support for comms
LorenzoMinto
pushed a commit
that referenced
this pull request
Jan 25, 2023
# This is the 1st commit message: Add federated client to BraveFederated component # This is the commit message #2: Remove unnecessary files # This is the commit message #3: Hook up learning service # This is the commit message #4: Unlink client with DataStore # This is the commit message #5: comment # This is the commit message #6: temp # This is the commit message #7: todos # This is the commit message #8: Change to follow Chromium styleguide # This is the commit message #9: Refactor 1 # This is the commit message #10: Use grpc_support for comms
LorenzoMinto
pushed a commit
that referenced
this pull request
Feb 14, 2023
# This is the 1st commit message: Add federated client to BraveFederated component # This is the commit message #2: Remove unnecessary files # This is the commit message #3: Hook up learning service # This is the commit message #4: Unlink client with DataStore # This is the commit message #5: comment # This is the commit message #6: temp # This is the commit message #7: todos # This is the commit message #8: Change to follow Chromium styleguide # This is the commit message #9: Refactor 1 # This is the commit message #10: Use grpc_support for comms
This was referenced May 4, 2023
25 tasks
tmancey
added a commit
that referenced
this pull request
Jun 6, 2023
Followup #3 to "Implement Search Result and New Tab Page ads attribution if ads are enabled or disabled"
fallaciousreasoning
added a commit
that referenced
this pull request
Jun 15, 2023
# This is the 1st commit message: Fix cr114 changes # This is the commit message #2: Begin work on GeoLocationClientObject # This is the commit message #3: Add ScopedBlockingCall # This is the commit message #4: Use AccuracyLevel # This is the commit message #5: WIP locationupdated signal # This is the commit message #6: Formatting # This is the commit message #7: Move initialization into the GeoClueClientObject # This is the commit message #8: Revert to CHECK
fallaciousreasoning
added a commit
that referenced
this pull request
Jul 24, 2023
# This is the 1st commit message: Fix cr114 changes # This is the commit message #2: Begin work on GeoLocationClientObject # This is the commit message #3: Add ScopedBlockingCall # This is the commit message #4: Use AccuracyLevel # This is the commit message #5: WIP locationupdated signal # This is the commit message #6: Formatting # This is the commit message #7: Move initialization into the GeoClueClientObject # This is the commit message #8: Revert to CHECK
25 tasks
aseren
added a commit
that referenced
this pull request
Apr 12, 2024
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes for comments on #2 , branch 'build-linux-output-name2'.
Created a new branch and PR because could not build and verify changes in 'build-linux-output-name'.