Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete and incomplete license file generation #5562

Merged
merged 1 commit into from
May 23, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented May 15, 2020

There is no real indication in the git history as to why this was added back in February 2018, but I suspect it was ported over from the muon browser.

Submitter Checklist:

Test Plan:

Open brave://credits and make sure that it works and displays a list of third-party components and their licenses.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier requested review from bridiver and bbondy May 15, 2020 02:11
@fmarier fmarier self-assigned this May 15, 2020
@fmarier fmarier added this to the 1.11.x - Nightly milestone May 15, 2020
There is no real indication in the git history as to why this was
added back in February 2018, but I suspect it was ported over from
the muon browser.
@fmarier fmarier force-pushed the francois-remove-obsolete-license-file branch from 8c1e3c7 to 37623df Compare May 22, 2020 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants