Make pull_l10n more lenient to localizer problems #6124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that they don't get accidentally committed
bbondy
force-pushed
the
transifex-lenient
branch
from
9c44a61
to
e3d5414
Compare
bbondy
commented
Jul 21, 2020
| val = (val.replace('&lt;', '<') | ||
| .replace('&gt;', '>') | ||
| .replace('&&', '&')) | ||
| # TODO(bbondy) we should also do fixups for ph tags here that localizers often mess up | ||
| .replace('&amp;', '&')) |
There was a problem hiding this comment.
calling out this is a separate fix from the rest.
This was referenced Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#10820
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.