Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update strings from Transifex (Uplift 1.12.x) #6178

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Update strings from Transifex (Uplift 1.12.x) #6178

merged 1 commit into from
Jul 23, 2020

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jul 22, 2020 •
edited by kjozwiak
Loading

Uplift of translation strings from #6174 and #6124

Resolves brave/brave-browser#10746
Resolves brave/brave-browser#10745
Resolves brave/brave-browser#10755

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bbondy bbondy added this to the 1.12.x - Beta milestone Jul 22, 2020
@bbondy bbondy requested a review from a team July 22, 2020 20:18
@bbondy bbondy self-assigned this Jul 22, 2020
@kjozwiak
Copy link
Member

Restarting Win x64 as build didn't complete due to losing all our Win instances ~5hrs ago (Agent was Removed) as per https://ci.brave.com/job/pr-brave-browser-l10n-fps-1.12.x/1/execution/node/284/log/.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jul 23, 2020
kjozwiak
kjozwiak approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.12.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6174 (comment).

@kjozwiak kjozwiak merged commit 0f269d7 into 1.12.x Jul 23, 2020
@kjozwiak kjozwiak deleted the l10n-fps-1.12.x branch July 23, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@bbondy bbondy

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging this pull request may close these issues.
2 participants
@bbondy @kjozwiak