Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tab contrast #6912

Merged
merged 14 commits into from
Nov 25, 2020
Merged

Improve tab contrast #6912

merged 14 commits into from
Nov 25, 2020

Commits on Nov 25, 2020

  1. Change toolbar/tab color of dark theme, private and tor window

    @simonhong
    simonhong committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    62309ca View commit details
    Browse the repository at this point in the history

  2. Adjust tab separator color of private/tor/guest

    @simonhong
    simonhong committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    ebca566 View commit details
    Browse the repository at this point in the history

  3. Cleanup AvatarToolbarButton patches

    @simonhong
    simonhong committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    58ac2d6 View commit details
    Browse the repository at this point in the history

  4. Re-style brave avatar button

    @simonhong
    simonhong committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    eda9d59 View commit details
    Browse the repository at this point in the history

  5. Update location bar focus ring color for non regular

    @simonhong
    simonhong committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    306be6e View commit details
    Browse the repository at this point in the history

  6. Update location/omnibox color

    @simonhong
    simonhong committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    87fe560 View commit details
    Browse the repository at this point in the history

  7. Paint graphic only on tor window frame

    @simonhong
    simonhong committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    a71c0a6 View commit details
    Browse the repository at this point in the history

  8. Update omnibox hover color on dark mode

    @simonhong
    simonhong committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    ad0982e View commit details
    Browse the repository at this point in the history

  9. Update private/tor label in profile menu view

    @simonhong
    simonhong committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    0bf37bc View commit details
    Browse the repository at this point in the history

  10. Remove using IsTorProfile() function after rebasing

    @simonhong
    simonhong committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    721c604 View commit details
    Browse the repository at this point in the history

  11. Use separated theme service for tor profile 

    As we use different theme colors for tor window(previously, same with private), we should
differentiate tor and private profile from ThemeHelper. However, upstream chromium uses
only two kinds of theme provider. One for orignal theme provider and the other is incognito
theme provider. If we want to add another theme provider for tor, it will add many patch files.
So, I think using different theme service for tor profile is simplest way to have tor specific
theme colors.
    @simonhong
    simonhong committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    77a0980 View commit details
    Browse the repository at this point in the history

  12. Update tooltip of tor avatar button

    @simonhong
    simonhong committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    82e5458 View commit details
    Browse the repository at this point in the history

  13. Avoid patching for theme_service_factory.cc

    @simonhong
    simonhong committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    7a7c9be View commit details
    Browse the repository at this point in the history

  14. Fix lint error

    @simonhong
    simonhong committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    d589649 View commit details
    Browse the repository at this point in the history