-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide topsite customization option till we have add shortcut feature #7105
Conversation
4879cd7
to
c61ae03
Compare
c61ae03
to
402e511
Compare
Disable NTP customization mode by default.
402e511
to
4008d0a
Compare
#if !defined(OS_ANDROID) | ||
// Turn on most visited mode on NTP by default. | ||
// We can turn customization mode on when we have add-shortcut feature. | ||
registry->SetDefaultPrefValue(prefs::kNtpUseMostVisitedTiles, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value might be getting overridden by Chromium (I'm not 100% sure)
Basically in https://github.com/brave/brave-core/blob/master/components/brave_new_tab_ui/containers/newTab/gridSites.tsx#L78, the tile is becoming draggable. If you drag this tile, it does actually move it and then it seems to activate custom links mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After troubleshooting, I re-ran npm run init
for this branch and built... and it worked perfectly 😄 I believe the problem was on my side. Everything looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfect! Nice and easy solution
Verification PASSED on
Ensured that the
Ensured that However, I did run into brave/brave-browser#12739 while attempting to verify brave/brave-browser#12378. I think there's still some issues there re: re-adding websites into |
Resolves brave/brave-browser#12378
Resolves brave/brave-browser#12354
Submitter Checklist:
npm run lint
,npm run gn_check
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).QA/Yes
orQA/No
) to the associated issuerelease-notes/include
orrelease-notes/exclude
) to the associated issueTest Plan:
A. Check customization toggle is hidden always.
B. Check most visited sites mode is on by default
use_most_visited_tiles
is set to true.C.
npm run test brave_browser_tests -- --filter=BraveProfilePrefsBrowserTest.*
Reviewer Checklist:
After-merge Checklist:
changes has landed on.