Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show badge for public subdomain gateways #8982

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Show badge for public subdomain gateways #8982

merged 2 commits into from
Jun 3, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jun 1, 2021

Resolves brave/brave-browser#16116

  • Show badge for public subdomain gateways

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@spylogsster spylogsster requested a review from bbondy June 1, 2021 15:35
@spylogsster spylogsster requested a review from a team as a code owner June 1, 2021 15:35
@spylogsster spylogsster force-pushed the issue-16116-2 branch 2 times, most recently from 375211f to 62c19a1 Compare June 1, 2021 15:40
Base automatically changed from ipfs-gateway-resolving to master June 2, 2021 14:08
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check if any deps are missing for the unit test includes. Otherwise ++

@spylogsster spylogsster merged commit ef91beb into master Jun 3, 2021
@spylogsster spylogsster deleted the issue-16116-2 branch June 3, 2021 09:10
@spylogsster spylogsster added this to the 1.27.x - Nightly milestone Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: "Open using IPFS" not shown on public subdomain gateways
3 participants