Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#8497 - Added 'Don't ask me again' button to Wayback Machine infobar #9030

Merged
merged 3 commits into from
Jun 10, 2021

Conversation

rahulsnkr
Copy link
Contributor

@rahulsnkr rahulsnkr commented Jun 7, 2021

Resolves brave/brave-browser#8497. Wayback machine infobar now shows a "Don't ask me again" button.

image

image

Scenarios

Scenario 1 - User clicks on "Don't ask again" button

wayback_scenario_1.mp4

Scenario 2 - User clicks on "Check for Saved Version" button

wayback_scenario_2.mp4

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

cc @rebron @simonhong

@rahulsnkr rahulsnkr requested a review from simonhong as a code owner June 7, 2021 15:28
@simonhong
Copy link
Member

@rahulsnkr Huge thanks for fixing this 👍
Need to check this PR with design team first. cc @karenkliu @rebron

Copy link

@karenkliu karenkliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯

@rahulsnkr
Copy link
Contributor Author

@simonhong addressed all comments and updated.

@simonhong simonhong mentioned this pull request Jun 10, 2021
24 tasks
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ with trivial comment.
Huge thanks for fixing this!

@simonhong
Copy link
Member

Got all green from CI with #9069.
@rahulsnkr huge thanks for fixing this! 👍

@simonhong simonhong merged commit 7374d00 into brave:master Jun 10, 2021
@simonhong simonhong added this to the 1.27.x - Nightly milestone Jun 10, 2021
@rahulsnkr rahulsnkr deleted the wayback-machine-dont-ask branch August 13, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Don't ask me again" pref to 404 Wayback machine infobar
3 participants