Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added select location ui on brave vpn w/o service logic #9914

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Conversation

nullhook
Copy link
Contributor

@nullhook nullhook commented Aug 31, 2021

Resolves brave/brave-browser#17770

Service logic isn't connected yet.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@nullhook nullhook added the bug label Aug 31, 2021
@nullhook nullhook changed the title added select location ui on brave vpn Added select location ui on brave vpn w/o service logic Aug 31, 2021
@nullhook nullhook requested a review from petemill August 31, 2021 04:37
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@nullhook nullhook merged commit bf3b1cb into master Sep 1, 2021
@nullhook nullhook deleted the vpn_webui branch September 1, 2021 15:35
@bsclifton bsclifton added this to the 1.31.x - Nightly milestone Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPN Panel - create a basic server selection UI w/o service logic
3 participants