Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Adjust frequency of data file checks
Browse files Browse the repository at this point in the history
Fix #5228

Auditors: @aekeus
  • Loading branch information
bbondy committed Oct 28, 2016
1 parent ca52818 commit 487dbed
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions js/constants/appConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,25 +45,25 @@ module.exports = {
alternateDataFiles: 'https://s3.amazonaws.com/adblock-data/{version}/{uuid}.dat',
url: 'https://s3.amazonaws.com/adblock-data/{version}/ABPFilterParserData.dat',
version: '2',
msBetweenRechecks: 1000 * 60 * 60 * 24, // 1 day
msBetweenRechecks: 1000 * 60 * 60 * 2, // 2 hours
enabled: true
},
safeBrowsing: {
url: 'https://s3.amazonaws.com/adblock-data/{version}/SafeBrowsingData.dat',
version: '2',
msBetweenRechecks: 1000 * 60 * 60 * 24, // 1 day
msBetweenRechecks: 1000 * 60 * 60 * 2, // 2 hours
enabled: true
},
trackingProtection: {
url: 'https://s3.amazonaws.com/tracking-protection-data/{version}/TrackingProtection.dat',
version: '1',
msBetweenRechecks: 1000 * 60 * 60 * 24, // 1 day
msBetweenRechecks: 1000 * 60 * 60 * 2, // 2 hours
enabled: true
},
httpsEverywhere: {
url: 'https://s3.amazonaws.com/https-everywhere-data/{version}/httpse.json',
version: '5.2', // latest major point release from https://eff.org/https-everywhere
msBetweenRechecks: 1000 * 60 * 60 * 24, // 1 day
msBetweenRechecks: 1000 * 60 * 60 * 12, // 1/2 day
enabled: true
},
siteHacks: {
Expand Down

3 comments on commit 487dbed

@bbondy
Copy link
Member Author

@bbondy bbondy commented on 487dbed Oct 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @garvankeeley @SergeyZhukovsky in case you want to match it

@garvankeeley
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile i think it is safe to just do the check on boot (actually I do it a minute or so after boot). Fabric indicates the app nearly never runs for more than 1 day. Either users swipe it away (and kill) or the OS decides it has been idle for too long and kills it.

@aekeus
Copy link
Member

@aekeus aekeus commented on 487dbed Oct 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Please sign in to comment.