From 96f5da46b17f1b89fe8530a313084a096f945f24 Mon Sep 17 00:00:00 2001 From: Cezar Augusto Date: Tue, 25 Jul 2017 21:07:34 -0300 Subject: [PATCH] add tests for tabContentState and create tabUtilTest --- .../app/common/state/tabContentStateTest.js | 22 +++++++++ test/unit/lib/tabUtilTest.js | 49 +++++++++++++++++++ 2 files changed, 71 insertions(+) create mode 100644 test/unit/lib/tabUtilTest.js diff --git a/test/unit/app/common/state/tabContentStateTest.js b/test/unit/app/common/state/tabContentStateTest.js index 9b9bbec5928..beb63389448 100644 --- a/test/unit/app/common/state/tabContentStateTest.js +++ b/test/unit/app/common/state/tabContentStateTest.js @@ -429,6 +429,18 @@ describe('tabContentState unit tests', function () { }) assert.equal(tabContentState.hasFixedCloseIcon(), false) }) + + it('frame is active and breakpoint is dynamic', function () { + getFrameByKeyMock = sinon.stub(frameStateUtil, 'getFrameByKey', () => { + return Immutable.fromJS({ + breakpoint: 'dynamic' + }) + }) + isFrameKeyActive = sinon.stub(frameStateUtil, 'isFrameKeyActive', () => { + return true + }) + assert.equal(tabContentState.hasFixedCloseIcon(), false) + }) }) describe('hasRelativeCloseIcon', function () { @@ -461,6 +473,16 @@ describe('tabContentState unit tests', function () { }) assert.equal(tabContentState.hasRelativeCloseIcon(state, frameKey), true) }) + + it('if hovering (tabIndex === hoverTabIndex) and break point is dynamic', function () { + const state = defaultWindowStore + getFrameByKeyMock = sinon.stub(frameStateUtil, 'getFrameByKey', () => { + return Immutable.fromJS({ + breakpoint: 'dynamic' + }) + }) + assert.equal(tabContentState.hasRelativeCloseIcon(state, frameKey), true) + }) }) describe('hasVisibleSecondaryIcon', function () { diff --git a/test/unit/lib/tabUtilTest.js b/test/unit/lib/tabUtilTest.js new file mode 100644 index 00000000000..ce8d6ed267b --- /dev/null +++ b/test/unit/lib/tabUtilTest.js @@ -0,0 +1,49 @@ +/* global describe, it */ +const tabUtil = require('../../../app/renderer/lib/tabUtil') +const tabBreakpoint = require('../../../app/renderer/components/styles/global').breakpoint.tab +const assert = require('assert') + +require('../braveUnit') + +describe('tabUtil', function () { + describe('getTabBreakpoint', function () { + let size + + it('returns `dynamic` if `dynamic` size matches', function () { + size = Number.parseInt(tabBreakpoint.dynamic, 10) + assert.equal(tabUtil.getTabBreakpoint(size), 'dynamic') + }) + it('returns `default` if `default` size matches', function () { + size = Number.parseInt(tabBreakpoint.default, 10) + assert.equal(tabUtil.getTabBreakpoint(size), 'default') + }) + it('returns `large` if `large` size matches', function () { + size = Number.parseInt(tabBreakpoint.large, 10) + assert.equal(tabUtil.getTabBreakpoint(size), 'large') + }) + it('returns `largeMedium` if `largeMedium` size matches', function () { + size = Number.parseInt(tabBreakpoint.largeMedium, 10) + assert.equal(tabUtil.getTabBreakpoint(size), 'largeMedium') + }) + it('returns `medium` if `medium` size matches', function () { + size = Number.parseInt(tabBreakpoint.medium, 10) + assert.equal(tabUtil.getTabBreakpoint(size), 'medium') + }) + it('returns `mediumSmall` if `mediumSmall` size matches', function () { + size = Number.parseInt(tabBreakpoint.mediumSmall, 10) + assert.equal(tabUtil.getTabBreakpoint(size), 'mediumSmall') + }) + it('returns `small` if `small` size matches', function () { + size = Number.parseInt(tabBreakpoint.small, 10) + assert.equal(tabUtil.getTabBreakpoint(size), 'small') + }) + it('returns `extraSmall` if `extraSmall` size matches', function () { + size = Number.parseInt(tabBreakpoint.extraSmall, 10) + assert.equal(tabUtil.getTabBreakpoint(size), 'extraSmall') + }) + it('returns `smallest` if `smallest` size matches', function () { + size = Number.parseInt(tabBreakpoint.smallest, 10) + assert.equal(tabUtil.getTabBreakpoint(size), 'smallest') + }) + }) +})