From baa0be0b2bffd4be29ab8ca8306b7e4a7e47d9a7 Mon Sep 17 00:00:00 2001 From: eV Date: Mon, 8 May 2017 23:16:47 +0000 Subject: [PATCH] Restore guard to populateHistory, fixes #8767 Auditors: @ayumi @bsclifton --- app/browser/tabs.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/browser/tabs.js b/app/browser/tabs.js index cbf42ff942c..884daa55162 100644 --- a/app/browser/tabs.js +++ b/app/browser/tabs.js @@ -96,7 +96,7 @@ const needsPartitionAssigned = (createProperties) => { // TODO(bridiver) - refactor this into an action ipcMain.on(messages.ABOUT_COMPONENT_INITIALIZED, (e) => { const tab = e.sender - const listener = () => { + const listener = (_diffs) => { if (!tab.isDestroyed()) { const tabValue = tabState.getByTabId(appStore.getState(), tab.getId()) if (tabValue && tabValue.get('active') === true) { @@ -167,7 +167,9 @@ const updateAboutDetails = (tab, tabValue) => { bookmarkFolders: bookmarkFolders.toJS() }) } else if (location === 'about:history' && history) { - appActions.populateHistory() + if (!history) { + appActions.populateHistory() + } tab.send(messages.HISTORY_UPDATED, history.toJS()) tab.send(messages.SETTINGS_UPDATED, appSettings.toJS()) } else if (location === 'about:extensions' && extensions) {