Better title handling with internationalization code

Always show torrent title -- even if internationalization code runs after it's set.
brave · Mar 18, 2017 · bd2d0c9 · bd2d0c9
1 parent efefed2
commit bd2d0c9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/app/extensions/torrent/locales/en-US/app.properties b/app/extensions/torrent/locales/en-US/app.properties
@@ -20,3 +20,4 @@ torrentLoadingInfo=Loading torrent info...
 torrentUntitled=Untitled torrent
 torrentLoadingMedia=Loading...
 copyMagnetLink=Copy Magnet Link
+webtorrentPage=WebTorrent
diff --git a/js/webtorrent/entry.js b/js/webtorrent/entry.js
@@ -54,8 +54,6 @@ function init () {
     return onError(new Error('Invalid torrent identifier'))
   }
 
-  document.title = store.name
-
   // Create the client, set up IPC to the WebTorrentRemoteServer
   client = new WebTorrentRemoteClient(send)
   client.on('warning', onWarning)
@@ -104,6 +102,7 @@ function send (msg) {
 function update () {
   const elem = <App store={store} dispatch={dispatch} />
   ReactDOM.render(elem, document.querySelector('#appContainer'))
+  document.title = store.name || 'WebTorrent'
 }
 
 function onAdded (err, torrent) {
@@ -124,7 +123,6 @@ function initTorrent (torrent) {
   // Once torrent's canonical name is available, use it
   if (torrent.name) {
     store.name = torrent.name
-    document.title = store.name
   }
 
   torrent.on('warning', onWarning)