diff --git a/js/about/bookmarks.js b/js/about/bookmarks.js index ff896e960b8..be1631f9cd0 100644 --- a/js/about/bookmarks.js +++ b/js/about/bookmarks.js @@ -37,14 +37,17 @@ class BookmarkFolderItem extends ImmutableComponent { onDrop (e) { const bookmark = dndData.getDragData(e.dataTransfer, dragTypes.BOOKMARK) + if (bookmark) { + // Don't allow a bookmark folder to be moved into itself + if (bookmark.get('folderId') === this.props.bookmarkFolder.get('folderId')) { + return + } aboutActions.moveSite(bookmark.toJS(), this.props.bookmarkFolder.toJS(), dndData.shouldPrependVerticalItem(e.target, e.clientY), true) } } render () { - const childBookmarkFolders = this.props.bookmarkFolder.get('folderId') === -1 - ? [] - : this.props.allBookmarkFolders + const childBookmarkFolders = this.props.allBookmarkFolders .filter((bookmarkFolder) => (bookmarkFolder.get('parentFolderId') || 0) === this.props.bookmarkFolder.get('folderId')) return
-