From dec12346b1d9525d404f34447dbdda67b1675131 Mon Sep 17 00:00:00 2001 From: Suguru Hirahara Date: Fri, 28 Jul 2017 09:26:37 +0900 Subject: [PATCH] Re-add navigationBarWrapper Addresses #9283 See discussion on https://github.com/brave/browser-laptop/pull/9851#discussion_r126899931 --- .../components/navigation/navigationBar.js | 6 +-- .../components/navigation/navigator.js | 39 ++++++++----------- app/renderer/components/navigation/urlBar.js | 7 ++-- 3 files changed, 22 insertions(+), 30 deletions(-) diff --git a/app/renderer/components/navigation/navigationBar.js b/app/renderer/components/navigation/navigationBar.js index 69287727b94..24eafd2210d 100644 --- a/app/renderer/components/navigation/navigationBar.js +++ b/app/renderer/components/navigation/navigationBar.js @@ -30,18 +30,14 @@ const frameStateUtil = require('../../../../js/state/frameStateUtil') // Utils const cx = require('../../../../js/lib/classSet') const {getBaseUrl} = require('../../../../js/lib/appUrlUtil') -const eventUtil = require('../../../../js/lib/eventUtil') const {getSetting} = require('../../../../js/settings') -const contextMenus = require('../../../../js/contextMenus') const bookmarkLocationCache = require('../../../common/cache/bookmarkLocationCache') const platformUtil = require('../../../common/lib/platformUtil') -const {isFullScreen} = require('../../currentWindow') +const isDarwin = platformUtil.isDarwin() // Styles const globalStyles = require('../styles/global') -const isDarwin = platformUtil.isDarwin() - class NavigationBar extends React.Component { mergeProps (state, ownProps) { const currentWindow = state.get('currentWindow') diff --git a/app/renderer/components/navigation/navigator.js b/app/renderer/components/navigation/navigator.js index e5c093d5a02..c3d7b7bf6bd 100644 --- a/app/renderer/components/navigation/navigator.js +++ b/app/renderer/components/navigation/navigator.js @@ -155,26 +155,6 @@ class Navigator extends React.Component { ipc.off(messages.SHORTCUT_ACTIVE_FRAME_FORWARD, this.onForward) } - // BEM Level: navigator__menuBarAndNavigationBar__navigationBarWrapper - get navigationBarWrapper () { - return
- {this.topLevelStartButtons} - { - this.props.showNavigationBar - ? - : null - } - {this.topLevelEndButtons} -
- } - // BEM Level: navigator__menuBarAndNavigationBar__navigationBarWrapper__topLevelStartButtons get topLevelStartButtons () { return
: null } - {this.navigationBarWrapper} +
+ {this.topLevelStartButtons} + { + this.props.showNavigationBar + ? + : null + } + {this.topLevelEndButtons} +
{ this.props.isCaptionButton @@ -425,7 +420,7 @@ const styles = StyleSheet.create({ whiteSpace: 'nowrap' }, - navigationBarWrapper: { + navigator__menuBarAndNavigationBar__navigationBarWrapper: { boxSizing: 'border-box', display: 'flex', justifyContent: 'space-between', diff --git a/app/renderer/components/navigation/urlBar.js b/app/renderer/components/navigation/urlBar.js index 2dd7de26989..ae3bc8bb872 100644 --- a/app/renderer/components/navigation/urlBar.js +++ b/app/renderer/components/navigation/urlBar.js @@ -37,14 +37,15 @@ const {eventElHasAncestorWithClasses, isForSecondaryAction} = require('../../../ const {getBaseUrl, isUrl} = require('../../../../js/lib/appUrlUtil') const {getCurrentWindowId} = require('../../currentWindow') const {normalizeLocation, getNormalizedSuggestion} = require('../../../common/lib/suggestion') -const isDarwin = require('../../../common/lib/platformUtil').isDarwin() +const platformUtil = require('../../../common/lib/platformUtil') const publisherUtil = require('../../../common/lib/publisherUtil') const historyUtil = require('../../../common/lib/historyUtil') -const isWindows = require('../../../common/lib/platformUtil').isWindows() + +const isDarwin = platformUtil.isDarwin() +const isWindows = platformUtil.isWindows() // Styles const iconNoScript = require('../../../../img/url-bar-no-script.svg') - const globalStyles = require('../styles/global') class UrlBar extends React.Component {