From e948fa3bcb0a06e47320a7b014c0abe28bfd1a1e Mon Sep 17 00:00:00 2001 From: Taylor `Riastradh' Campbell Date: Thu, 28 Jun 2018 21:45:06 +0000 Subject: [PATCH] Use a different socks port number for channel ''. Channel '' apparently happens for local builds, and we don't want it to step on the toes of release builds. fix #14592 This is a stop-gap measure until we use an OS-chosen socks port number or a local socket as in #12936. Auditors: @diracdeltas @bsclifton Test Plan: 1. Launch a local development build of Brave. 2. Laucnh a release build of Brave. 3. Confirm that Tor works in both. --- app/channel.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/channel.js b/app/channel.js index f15dbe7ad8c..47a4dde1fd8 100644 --- a/app/channel.js +++ b/app/channel.js @@ -67,7 +67,6 @@ exports.getTorSocksProxy = () => { let portno switch (channel) { case 'dev': - case '': default: portno = 9250 break @@ -80,6 +79,9 @@ exports.getTorSocksProxy = () => { case 'developer': portno = 9280 break + case '': + portno = 9290 + break } return `socks5://127.0.0.1:${portno}` }