Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Torrent viewer URL bar has border radius #10692

Closed
srirambv opened this issue Aug 28, 2017 · 8 comments · Fixed by #12897
Closed

Torrent viewer URL bar has border radius #10692

srirambv opened this issue Aug 28, 2017 · 8 comments · Fixed by #12897

Comments

@srirambv
Copy link
Collaborator

srirambv commented Aug 28, 2017

Test plan

  1. Enable Brave payments
  2. Visit https://webtorrent.io/torrents/big-buck-bunny.torrent
  3. Put mouse over title bar area if needed (if title bar is enabled)
  4. URL bar should not have border radius with publisher icon

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Torrent viewer URL bar has border radius

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):

Brave 0.19.3
rev 0adbd61
Muon 4.4.11
  • Steps to reproduce:

    1. Visit https://webtorrent.io/torrents/big-buck-bunny.torrent
    2. URL bar has border radius with publisher icon
    3. Open a new tab, visit any site, URL bar doesn't have any border radius
  • Actual result:
    See screenshot

  • Expected result:
    Should only show border radius when publisher icon is not shown

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    image

  • Any related issues:
    Publisher icon not properly aligned with URL bar #7449

@srirambv srirambv added feature/URLbar polish Nice to have — usually related to front-end/visual tasks. QA/test-plan-specified labels Aug 28, 2017
@srirambv srirambv added this to the 0.21.x (Nightly Channel) milestone Aug 28, 2017
@luixxiul luixxiul added bug and removed polish Nice to have — usually related to front-end/visual tasks. labels Aug 29, 2017
@alexwykoff alexwykoff removed this from the 0.21.x (Nightly Channel) milestone Aug 29, 2017
@bsclifton bsclifton modified the milestones: Backlog (Prioritized), Triage Backlog Nov 27, 2017
@arsalankhalid
Copy link
Contributor

Is this issue still available? I'd like to take this over :)

@bsclifton
Copy link
Member

bsclifton commented Jan 26, 2018

@arsalankhalid absolutely! I'll assign myself so that nobody grabs it 😄

Let me know if you have any questions

@bsclifton bsclifton self-assigned this Jan 26, 2018
@arsalankhalid
Copy link
Contributor

Sure thing, thanks for the quick response. How come it's assigned to you though, shouldn't it be assigned to the developer carrying out the task (:

But will carry this out!

@arsalankhalid
Copy link
Contributor

I'm not sure I'm seeing what you're describing, i.e:

image

Any advice?

@bsclifton
Copy link
Member

bsclifton commented Jan 28, 2018

@arsalankhalid It's hard to spot- but the right-hand side of the URL bar should not be rounded (for some reason, it has border-radius). It should be square, like this:
screen shot 2018-01-27 at 11 13 03 pm

Your screenshot shows it rounded
screen shot 2018-01-27 at 11 15 25 pm

I assigned myself since you are not added to the Brave organization or the browser-laptop repo 😄 Unfortunately, GitHub won't allow people to be assigned unless they're added OR they're the one who opened the issue

@arsalankhalid
Copy link
Contributor

arsalankhalid commented Jan 28, 2018

Ah thank you sir, much more noticeable now.
Investigating the styles by looking at global.js in components > styles, still not able to figure out how its happening only on this site, but playing around with the CSS. I'll figure it out.

Cheers

@arsalankhalid
Copy link
Contributor

Here you are sir: #12897
Note that I changed a line in the docs too, found the directory structure there to be wrong, and also effed up a commit, so reverted it. There doesn't seem to be aggressiveness on dirty commits in PRs from what I've seen so far, but if preferred than I can remove it.

Thanks for your help thus far, if solution too hacky please advise :)

@srirambv
Copy link
Collaborator Author

srirambv commented Jun 14, 2018

Verified on Windows x64 using

  • 0.23.8 06c657b
  • muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified with macOS 10.12.6 using

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.