Disabling Torrent Viewer doesn't disable Torrent Handling

[jonathansampson]

Test plan

1. Visit about:preferences#extensions and disable Torrent Viewer (if not already disabled)
2. Restart if prompted
3. Verify extension is disabled
4. Visit https://www.qubes-os.org/downloads/
5. Click Torrent button
6. You should be prompted to save the torrent file

Original issue description

Did you search for similar issues before submitting this one?

Yes

Describe the issue you encountered:

Brave's native handling of .torrent files can be problematic for some sites (#10672). In an attempt to work around this issue, I sought to disable the built-in Web Torrent extension. Unfortunately, Brave still attempts to pass .torrent requests off to Web Torrent, which is unavailable after being disabled.

Platform (Win7, 8, 10? macOS? Linux distro?):

Desktop

Brave Version (revision SHA):

0.18.23 (36ae2ec)

Steps to reproduce:

1. Disable Torrent Viewer in about:preferences#extensions (and restart Brave)
2. Open Brave, then attempt watch a video on bitchute.com
3. Note that Brave attempts to pass .torrent requests to extension

Actual result:

Brave attempts to handle torrent requests long after Torrent Viewer has been disabled.

Expected result:

Disabling Torrent Viewer causes Brave to leave .torrent requests alone.

Will the steps above reproduce in a fresh profile? If not what other info can be added?

Yes

Is this an issue in the currently released version?

Yes

Can this issue be consistently reproduced?

Yes

Screenshot if needed:

Any related issues:

#10672

[luixxiul]

I remember @srirambv maybe has reported a similar issue for a while ago.

[eljuno]

+1 from community https://community.brave.com/t/still-referencing-torrent-extension-after-disabled/5358?u=eljuno

[pongraczi]

+1 Linuxmint 64 bit
Brave: 0.18.29
rev: 85f059d
Muon: 4.3.16
libchromiumcontent: 60.0.3112.113
V8: 6.0.286.56
Node.js: 7.9.0
Update Channel: dev
OS Platform: Linux
OS Release: 4.11.0-14-lowlatency
OS Architecture: x64

[pongraczi]

Still exists in
Brave: 0.18.32
rev: e94738d
Muon: 4.3.18
libchromiumcontent: 61.0.3163.71
V8: 6.1.534.31
Node.js: 7.9.0
Update Channel: dev
OS Platform: Linux
OS Release: 4.11.0-14-lowlatency
OS Architecture: x64

[pongraczi]

FYI: still exists in

Brave: 0.19.24
rev: 3b3fba2
Muon: 4.4.25
libchromiumcontent: 61.0.3163.100
V8: 6.1.534.41
Node.js: 7.9.0
Update Channel: Beta
OS Platform: Linux
OS Release: 4.11.0-14-lowlatency
OS Architecture: x64

[srirambv]

+1 from community https://community.brave.com/t/brave-closes-the-page-and-tries-to-download-torrent/10214/2

[bsclifton]

@vaguiners let's keep it civil in here please. I would like this issue fixed too, but let's refrain from using nasty language

[ocramc]

Still present in 0.20.30, release channel

[hugobuddel]

The torrent file is actually downloaded in 0.20.30 though, so it is not that problematic. But since #11452 is fixed, I'll try to reenable the plugin.

[pongraczi]

Still exists:

Brave: 0.20.46 
V8: 6.4.388.41 
rev: 5eb035c2d68225994a572a1d62861cf961355ab2 
Muon: 4.8.2 
OS Release: 4.13.0-32-generic 
Update Channel: Release 
OS Architecture: x64 
OS Platform: Linux 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 64.0.3282.140

[bsclifton]

+1 from @kjozwiak via #13619

Saving .torrent files while Torrent Viewer is disabled via about:preferences#extensions will produce a This site can’t be reached tab page while the Save as.. prompt is displayed.

Looks like this should have originally been fixed with #8452 but has regressed.

Steps to Reproduce

1. launch 0.22.7 8bb7e77
2. disable torrent viewer via about:preferences#extensions
3. visit https://www.qubes-os.org/downloads/ and click on the Torrent download

You'll notice that the 'Save as..modal will correctly be displayed, but at the same time, you'll receive theThis site can’t be reached` tab.

Actual result:

[pongraczi]

Still not working and seems worse than ever. I even cannot save a torrent file, I have to start chromium to be able to download a torrent file.
It is about 6 months old bug.
What if you just remove this feature completely?
I would be satisfied with that I can download a *.torrent file to save it, nothing else.

Brave: 0.22.669 
V8: 6.6.346.24 
rev: 6cda2e84f749e66409e9e3bca63f5796422e7edf 
Muon: 5.2.7 
OS Release: 4.13.0-38-generic 
Update Channel: Release 
OS Architecture: x64 
OS Platform: Linux 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 66.0.3359.117

[rzemykers]

+1

[lvella]

It is sad to not be able to use the browser because you can't download a plain torrent file.

[kjozwiak]

@bsclifton can we include this into https://github.com/brave/browser-laptop/milestone/114? @NejcZdovc has a PR ready and we've gotten a good amount of folks from the community that would like this fixed as well.

[LaurenWags]

Verified with macOS 10.12.6 using

• 0.22.718 11dcd19
• muon 6.0.12
• libchromiumcontent 66.0.3359.170

Verified with Ubuntu 17.10 x64

• 0.22.718 11dcd19
• muon 6.0.12
• libchromiumcontent 66.0.3359.170

[srirambv]

@bsclifton @NejcZdovc does the fix for the issue removes handling of .torrent files? With Torrent viewer enabled in extensions, clicking a .torrent file used load it in the tab for download but not any more. Is this expected?

[NejcZdovc]

@srirambv so torrent viewer is not loaded anymore if you have it enabled?

[srirambv]

@NejcZdovc yes correct

[NejcZdovc]

let me try it

[NejcZdovc]

@srirambv yes it's a problem and will fix it

[GeetaSarvadnya]

Verified on Windows x64 with

• 0.22.719 a9e0956
• muon 6.0.12
• libchromiumcontent 66.0.3359.170

Verified with macOS 10.12.6 using

• 0.22.719 a9e0956
• muon 6.0.12
• libchromiumcontent 66.0.3359.170
• Followed Test Plan as well as these steps:
  Scenario 1
  Enable Torrent viewer
  Visit the page and click on torrent
  should load the torrent viewer page
  Save torrent should download torrent and not show the error page
  start download should start download
  Scenario 2
  Disable torrent viewer
  visit the page and click on torrent
  should download torrent and not show the error page

Verified on Ubuntu 17.10 x64

• 0.22.719 a9e0956
• muon 6.0.12
• libchromiumcontent 66.0.3359.170