Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Switch order should be same on the bravery shield panel and the preference page #10813

Closed
luixxiul opened this issue Sep 6, 2017 · 1 comment

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 6, 2017

Test plan

#10816 (comment)


Describe the issue you encountered: Switch order should be same on the bravery shield panel and the preference page.

On the compact panel:

clipboard01

On the preference page:

clipboard01

  • Platform (Win7, 8, 10? macOS? Linux distro?): All

  • Brave Version (revision SHA): 0.18.x

  • Actual result: See above

  • Expected result: Block Phishing / Malware option should be moved to the bottom, following the panel.

    For reference this is the original panel switch alignment:

    clipboard01

  • Any related issues:


on the master branch the fingerprinting protection option has been moved to a pulldown option.

@srirambv
Copy link
Collaborator

Updated screenshot for reference
about:preferences#shields
image
Compact shields panel
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.