Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

bookmarkLocation is not working recursively when deleting folder #10908

Closed
NejcZdovc opened this issue Sep 12, 2017 · 1 comment
Closed

bookmarkLocation is not working recursively when deleting folder #10908

NejcZdovc opened this issue Sep 12, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Sep 12, 2017 •
edited by luixxiul
Loading

Test plan

#10909 (comment)

Describe the issue you encountered:
When deleting folder that has multiple child levels only first level is deleted from the state
@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Sep 12, 2017
@NejcZdovc NejcZdovc self-assigned this Sep 12, 2017
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Sep 12, 2017 •
edited
Loading

After a little more investigation I found out that the only thing that is not working is bookmarkLocation, everything else is deleted correctly.

@NejcZdovc NejcZdovc reopened this Sep 12, 2017
@NejcZdovc NejcZdovc changed the title Folder deletion is not working recursively bookmarkLocation is not working recursively when deleting folder Sep 12, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 12, 2017
@NejcZdovc
Fixes removal of bookmarkLocation cache when removin bookmark folder
10e4801 
Resolves brave#10908

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Sep 12, 2017
Merged
8 tasks
NejcZdovc added a commit that referenced this issue Sep 12, 2017
@NejcZdovc
Merge pull request #10909 from NejcZdovc/hotfix/#10908-bookmarkLocation
3da1304 
Fixes removal of bookmarkLocation cache when removing bookmark folder
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@bbondy @luixxiul @NejcZdovc @srirambv @LaurenWags