Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

shift+click in a sortable table is broken after sorting it #10971

Closed
diracdeltas opened this issue Sep 15, 2017 · 1 comment · Fixed by #11056
Closed

shift+click in a sortable table is broken after sorting it #10971

diracdeltas opened this issue Sep 15, 2017 · 1 comment · Fixed by #11056
Assignees
@diracdeltas
Labels
bug feature/history QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Sep 15, 2017 •
edited by luixxiul
Loading

Test plan

#11056 (comment)

  • Did you search for similar issues before submitting this one?
    yes

  • Platform (Win7, 8, 10? macOS? Linux distro?): osx

  • Brave Version (revision SHA): i checked on both master b0d7fc0 and 0.18.36

  • Steps to reproduce:

    1. go to about:history
    2. click on the 'Title' header to sort by title
    3. try selecting multiple entries in the table using shift+click

  • Actual result:
    seemingly random entries are selected

  • Expected result:
    the entries in the selection range should be selected

  • Is this an issue in the currently released version?
    yes

screen shot 2017-09-15 at 6 13 04 pm
@diracdeltas diracdeltas added this to the 0.20.x (Developer Channel) milestone Sep 15, 2017
@diracdeltas diracdeltas mentioned this issue Sep 15, 2017
Closed
@alexwykoff alexwykoff removed this from the 0.20.x (Developer Channel) milestone Sep 19, 2017
@diracdeltas diracdeltas changed the title multi-select in a sortable table is broken after sorting it shift+click in a sortable table is broken after sorting it Sep 20, 2017
@diracdeltas diracdeltas self-assigned this Sep 20, 2017
@diracdeltas diracdeltas added this to the 0.20.x (Developer Channel) milestone Sep 20, 2017
@diracdeltas
Copy link
Member Author

@alexwykoff i added this to 0.20.x because it blocks #1991 but it can also go in 0.21.x

diracdeltas added a commit that referenced this issue Sep 20, 2017
@diracdeltas
fix table multi-select after sort
4c8c8e9 
fix #10971

test plan:
1. browse some sites, then go to about:history
2. click on any of the columns to sort the table
3. shift+click to select multiple entries
4. contiguous table entries should be selected, not random entries
diracdeltas added a commit that referenced this issue Sep 20, 2017
@diracdeltas
fix table multi-select after sort
3b31018 
fix #10971

test plan:
1. browse some sites, then go to about:history
2. click on any of the columns to sort the table
3. shift+click to select multiple entries
4. contiguous table entries should be selected, not random entries
@diracdeltas diracdeltas mentioned this issue Sep 20, 2017
Merged
8 tasks
@luixxiul luixxiul added the bug label Sep 21, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@diracdeltas @syuan100
fix table multi-select after sort
aec4915 
fix brave#10971

test plan:
1. browse some sites, then go to about:history
2. click on any of the columns to sort the table
3. shift+click to select multiple entries
4. contiguous table entries should be selected, not random entries
This was referenced Dec 20, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug feature/history QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

fix table multi-select after sort brave/browser-laptop
6 participants
@diracdeltas @alexwykoff @luixxiul @NejcZdovc @srirambv @LaurenWags