Build from source causes white screen

[srirambv]

Test plan

1. run the following:

git clone git@github.com:brave/browser-laptop.git
cd browser-laptop
npm install
npm run watch

2. in a second console window, run:

npm start

3. Verify browser comes up as expected

Original issue description

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  Build from source causes white screen

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64

• Brave Version (revision SHA):
  master

• Steps to reproduce:

  1. Build from source
  2. npm start launches the browser but is unuseable only white screen no tabs

• Actual result:
  See Screenshot

• Expected result:

• Will the steps above reproduce in a fresh profile? If not what other info can be added?

• Is this an issue in the currently released version?

• Can this issue be consistently reproduced?

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:

npm start
 brave@0.21.0 start E:\srirambv\master\browser-laptop
> node ./tools/start.js --user-data-dir=brave-development --enable-logging --v=0 --enable-extension-activity-logging --enable-sandbox-logging --enable-dcheck

Crash reporting enabled
Error: unrecognized flag --icu_case_mapping
Try --help for options
[7120:6456:0918/092026.182:ERROR:CONSOLE(0)] "(WEBUI context) http://localhost:8080/gen/app.entry.js:17026: Uncaught AssertionError: state must be an Immutable.Map{AssertionError: state must be an Immutable.Map
    at validateState (http://localhost:8080/gen/app.entry.js:24302:10)
    at Object.getByWindowId (http://localhost:8080/gen/app.entry.js:24369:13)
    at isFocused (http://localhost:8080/gen/app.entry.js:15425:27)
    at mergeProps (http://localhost:8080/gen/app.entry.js:73047:23)
    at buildPropsImpl (http://localhost:8080/gen/app.entry.js:9562:10)
    at ReduxComponent.buildProps (http://localhost:8080/gen/app.entry.js:9634:12)
    at new ReduxComponent (http://localhost:8080/gen/app.entry.js:9592:23)
    at http://localhost:8080/gen/app.entry.js:55384:18
    at measureLifeCyclePerf (http://localhost:8080/gen/app.entry.js:55165:12)
    at ReactCompositeComponentWrapper._constructComponentWithoutOwner (http://localhost:8080/gen/app.entry.js:55383:16)}", source: chrome://brave/E:/srirambv/master/browser-laptop/app/extensions/brave/index-dev.html (0)

• Any related issues:

[syuan100]

+1 on mac osx

[cezaraugusto]

can you guys try again? should be ok now

[syuan100]

works now! thanks

[bsclifton]

Fixed with #10991

[bsclifton]

Verified building from master works great on Windows and macOS (after #10991) 👍

[srirambv]

Worked on Win x64