Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

extension icons do not appear at top right of app #11142

Closed
kevinlawler opened this issue Sep 25, 2017 · 1 comment
Closed

extension icons do not appear at top right of app #11142

kevinlawler opened this issue Sep 25, 2017 · 1 comment
Assignees
@kevinlawler
Labels
0.20.x issue first seen in 0.20.x bug feature/extensions priority/P2 Crashes. Loss of data. Severe memory leak. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@kevinlawler
Copy link
Contributor

Description

Extensions like Pocket or Pinterest do not have their icons appear in the top right of the app. This is due to the wrong protocol (file://) being caught by CSP restrictions.

Steps to Reproduce

Build and load browser. Turn on Pocket extension

Actual result:
screen shot 2017-09-25 at 2 29 12 pm

Note vertical grey bar |.

Expected result:
Pocket icon should appear.

Reproduces how often:
100%

Brave Version

Brave: 0.21.0
V8: 6.1.534.39
rev: 2513065
Muon: 4.6.3
OS Release: 16.7.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.3.5
libchromiumcontent: 61.0.3163.98

Reproducible on current live release:
No. Not a problem on the live build.

Additional Information

None
kevinlawler added a commit that referenced this issue Sep 25, 2017
@kevinlawler
extension icons should appear (macOS)
b0b367b 
changes file:// to chrome://brave

Issue #11142

Auditors:
@bridiver @diracdeltas @darkdh @jonathansampson

fix whitespace
@kevinlawler kevinlawler mentioned this issue Sep 25, 2017
Merged
@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Sep 26, 2017
kevinlawler added a commit that referenced this issue Sep 26, 2017
@kevinlawler
extension icons should appear (macOS)
1bc13ba 
changes file:// to chrome://brave

Issue #11142

Auditors:
@bridiver @diracdeltas @darkdh @jonathansampson

fix whitespace

add unit test
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel), Backlog Oct 25, 2017
@alexwykoff alexwykoff added the priority/P4 Minor loss of function. Workaround usually present. label Oct 31, 2017
@bbondy bbondy modified the milestones: Triage Backlog, Prioritized Backlog Nov 2, 2017
@bsclifton bsclifton mentioned this issue Nov 20, 2017
Closed
bsclifton pushed a commit that referenced this issue Dec 22, 2017
@kevinlawler @bsclifton
extension icons should appear (macOS)
a51b7ea 
changes file:// to chrome://brave

Issue #11142

Auditors:
@bridiver @diracdeltas @darkdh @jonathansampson

fix whitespace

add unit test
@bsclifton bsclifton changed the title extension icons do not appear at top right of app (macOS) extension icons do not appear at top right of app Dec 22, 2017
@bsclifton bsclifton modified the milestones: Backlog (Prioritized), 0.20.x (Beta Channel) Dec 22, 2017
@bsclifton bsclifton mentioned this issue Dec 22, 2017
Closed
@bsclifton bsclifton added priority/P2 Crashes. Loss of data. Severe memory leak. release/blocking 0.20.x issue first seen in 0.20.x regression and removed priority/P4 Minor loss of function. Workaround usually present. labels Dec 22, 2017
@bsclifton
Copy link
Member

Fixed with #11143

This was referenced Dec 27, 2017
Closed
Closed
Closed
This was referenced Jan 2, 2018
Closed
Closed
@bsclifton bsclifton mentioned this issue Jan 23, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kevinlawler kevinlawler

Labels
0.20.x issue first seen in 0.20.x bug feature/extensions priority/P2 Crashes. Loss of data. Severe memory leak. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
8 participants
@kevinlawler @bbondy @alexwykoff @luixxiul @bsclifton @NejcZdovc @srirambv @LaurenWags