Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Display confirmation dialog when clicking the trash icon on about:payments ledger table #11164

Closed
luixxiul opened this issue Sep 27, 2017 · 2 comments
Closed

Display confirmation dialog when clicking the trash icon on about:payments ledger table #11164

luixxiul opened this issue Sep 27, 2017 · 2 comments
Assignees
@ryanml
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include suggestion
Milestone
0.23.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 27, 2017 •
edited by bsclifton
Loading

Test plan

See #13128

Description

Display confirmation dialog when clicking the trash icon on about:payments ledger table.

Steps to Reproduce

  1. Visit some sites
  2. Open about:payments
  3. Click a trash icon

Actual result:

The entry is deleted without confirmation and you cannot redo deletion

Expected result:

The entry should be deleted with confirmation

Reproduces how often: [What percentage of the time does it reproduce?]

Brave Version

about:brave info:

Brave: 0.19.17
rev: e7e4365
Muon: 4.4.20
libchromiumcontent: 61.0.3163.98
V8: 6.1.534.39
Node.js: 7.9.0
Update Channel: Beta
OS Platform: Microsoft Windows
OS Release: 10.0.14393
OS Architecture: x64

Reproducible on current live release:

Reproducible.

Additional Information

#4634 (comment)
@luixxiul luixxiul changed the title Display confirmation dialog when clicking the trash icon on about;payments ledger table Display confirmation dialog when clicking the trash icon on about:payments ledger table Sep 27, 2017
@luixxiul luixxiul mentioned this issue Oct 9, 2017
Closed
@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
@ryanml ryanml mentioned this issue Feb 13, 2018
Closed
10 tasks
@bsclifton bsclifton modified the milestones: Triage Backlog, 0.23.x (Nightly Channel) Feb 13, 2018
@ryanml ryanml mentioned this issue Feb 19, 2018
Merged
10 tasks
@NejcZdovc
Copy link
Contributor

closed with #13182

This was referenced Jun 11, 2018
Closed
Closed
Closed
This was referenced Jun 19, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 19, 2018 •
edited by LaurenWags
Loading

Verified on Windows 10 x64 using

  • 0.23.11 - 6565c06
  • Muon - 7.1.0
  • libchromiumcontent - 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.11 - 6565c06
  • Muon - 7.1.0
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.11 6565c06
  • Muon 7.1.0
  • libchromiumcontent 67.0.3396.87

@srirambv srirambv mentioned this issue Jun 21, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Jun 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryanml ryanml

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include suggestion
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
8 participants
@luixxiul @cezaraugusto @bsclifton @ryanml @NejcZdovc @srirambv @LaurenWags @btlechowski