This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
The first browserButton with 'groupedItem' should have margin-left: 0 #11288
Assignees
Labels
misc/button
polish
Nice to have — usually related to front-end/visual tasks.
QA/checked-Linux
QA/checked-macOS
QA/checked-Win64
QA/test-plan-specified
release-notes/exclude
Milestone
Comments
luixxiul
added
misc/button
polish
8 tasks
syuan100
pushed a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 9, 2017
Closes brave#11288 Auditors: Test Plan: 1. Open about:styles 2. Click 'buttons' 3. Make sure the first button in a group does not have the left margin
This was referenced Dec 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
#11290 (comment)
Description
The first browserButton with 'groupedItem' should have
margin-left: 0.':first-child'pseudo-class should take care of that.Note that the buttons have to have a parent. Beginning with Selectors Level 4, that is no longer required.
Steps to Reproduce
buttonsActual result:
The first button in a group has the margin-left.
Expected result:
It should not.
Reproduces how often: [What percentage of the time does it reproduce?]
Brave Version
about:brave info:
Brave: 0.21.0
V8: 6.1.534.41
rev: d6447e8
Muon: 4.4.25
OS Release: 16.7.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.3.5
libchromiumcontent: 61.0.3163.100
Reproducible on current live release:
Additional Information
On the new add funds dialog:
The
ETHbutton has the left margin.The text was updated successfully, but these errors were encountered: